Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: js error when multiple invitations

Download Browse

Expected behavior ----------------- Go to project dashboard or tracker reports. Open invite modale and invite someone. ➡️ feedback should be displayed. Close the modal and without reloading the page, invite someone else. ➡️ feedback should be displayed. Current behavior ---------------- At the second invitation no feedback is displayed (modal is mostly empty) because lit-html does not like the way feedbacks container is cleared between two invitations. Currently we are doing `feedback.innerHTML = ""` to clear the container, but this removes lit-html comment nodes (e.g. `<!--?lit$48048164$-->`) that are used by the library. Bonus ----- Took the opportunity to add missing styles in FlamingParrot alerts to align the L&F with BurningParrot. Part of story #30021: Invite buddies to my Tuleap project Change-Id: Ie838f82de384c02675d5bde326387426be5dc964

+60 −1
Nicolas Terray (nterray) 2023-02-27 17:36
Nicolas Terray (nterray) 2023-02-27 17:44
51856b28b20df1d807921d1406f712962ec49a86
ace25fa589f4a9b38af4121c3d831e4a5e0c4fe6
git #tuleap/stable/51856b28b20df1d807921d1406f712962ec49a86

Modified Files

Side by side diff
Inline diff
Name
M src/scripts/main/src/invite-buddies/feedback-display.test.ts +33 −0 Go to diff View file
M src/scripts/main/src/invite-buddies/feedback-display.ts +1 −1 Go to diff View file
M src/themes/FlamingParrot/css/utils/_bootstrap-overrides.scss +26 −0 Go to diff View file