stable
Clone or download
This is a proposition to manage the permissions for ugroups authorized to set builds status via the route /git/:id_or_path/statuses/:commit_ref I have chosen the ci-token pane, as this is the place to manage the access to this route. Also I have chosen not to use the legacy permission mecanism using the "permission" table. [Bonus]: I took the opportunity to remove a bit of crappiness in the existing tab. part of: story #18320 native support of pull requests in tuleap branch source jenkins plugin How to test: - Go to the ci-token pane of one of your git repositories - Pick up several user_groups - Submit --> Selected user groups are marked as selected in the select box --> Permissions are saved in db - No functional change expected for token regeneration Change-Id: Ia089e12b570fc84865eefd87628803b42414a9b2
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/db/install.sql | +5 | −0 | Go to diff View file |
| A | plugins/git/db/mysql/updates/2021/202103151153_add_change_build_status_permissions_table.php | +44 | −0 | Go to diff View file |
| M | plugins/git/db/uninstall.sql | +1 | −0 | Go to diff View file |
| M | plugins/git/include/AccessRightsPresenterOptionsBuilder.php | +1 | −3 | Go to diff View file |
| A | plugins/git/include/CIToken/BuildStatusChangePermissionDAO.php | +50 | −0 | Go to diff View file |
| A | plugins/git/include/CIToken/BuildStatusChangePermissionManager.php | +54 | −0 | Go to diff View file |
| A | plugins/git/include/CIToken/CITokenPanePresenterBuilder.php | +69 | −0 | Go to diff View file |
| A | plugins/git/include/CIToken/CITokenPresenter.php | +67 | −0 | Go to diff View file |
| M | plugins/git/include/Git/Repository/Settings/CITokenController.php | +28 | −4 | Go to diff View file |
| M | plugins/git/include/Git/Repository/Settings/CITokenRouter.php | +3 | −0 | Go to diff View file |
| M | plugins/git/include/GitViews/RepoManagement/Pane/CIToken.class.php | +19 | −13 | Go to diff View file |
| M | plugins/git/include/gitPlugin.php | +9 | −1 | Go to diff View file |
| M | plugins/git/site-content/fr_FR/LC_MESSAGES/tuleap-git.po | +21 | −1 | Go to diff View file |
| M | plugins/git/templates/ci-token-pane.mustache | +33 | −6 | Go to diff View file |
| A | plugins/git/templates/set-build-status-permissions.mustache | +30 | −0 | Go to diff View file |