stable

Clone or download

Read-only

request #13391: Sending a mail notification can crash if the project is private and the notification is sent by a non web process

The \URLVerification class should not be used for anything that might work outside of the web context. The only legitimate usage of this class is in pure web controller or before those controllers. Change-Id: I7d844eb719aaeb1b4aea2373ea25815174016d93

Modified Files

Name
M plugins/docman/include/ApprovalTable/Reminder.class.php +11 −1 Go to diff View file
M plugins/docman/include/ApprovalTable/Reviewer/ReviewerFactory.class.php +13 −3 Go to diff View file
M plugins/docman/include/Docman_HTTPController.class.php +8 −2 Go to diff View file
M plugins/docman/include/Notifications/NotificationBuilders.php +13 −2 Go to diff View file
M plugins/docman/include/docmanPlugin.class.php +11 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionApprovalCreate.class.php +12 −2 Go to diff View file
M plugins/git/hooks/post-receive.php +12 −2 Go to diff View file
M plugins/git/include/gitPlugin.class.php +7 −1 Go to diff View file
M plugins/mediawiki/include/mediawikiPlugin.class.php +7 −11 Go to diff View file
M plugins/statistics/include/statisticsPlugin.class.php +2 −1 Go to diff View file
M plugins/svn/bin/svn_post_commit.php +11 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/MailSender.php +14 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact.class.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/DateReminder/Tracker_DateReminderManager.class.php +11 −1 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +2 −1 Go to diff View file
M plugins/webdav/include/FS/WebDAVRoot.class.php +7 −9 Go to diff View file
A src/common/Project/DelegatedUserAccessForProject.php +60 −0 Go to diff View file
M src/common/Project/ProjectAccessChecker.php +22 −1 Go to diff View file
M src/common/REST/ProjectStatusVerificator.php +3 −1 Go to diff View file
M src/common/backend/BackendSVN.class.php +2 −1 Go to diff View file
M src/common/frs/FRSPermissionManager.php +3 −1 Go to diff View file
M src/common/frs/FRSReleaseFactory.class.php +11 −2 Go to diff View file
M src/common/frs/FileModuleMonitorFactory.class.php +21 −3 Go to diff View file
M src/common/include/URLVerification.class.php +4 −24 Go to diff View file
M src/common/mail/MailFilter.php +13 −13 Go to diff View file
M src/common/wiki/phpwiki/lib/WikiNotification.php +8 −2 Go to diff View file
M src/www/soap/common/group.php +2 −1 Go to diff View file
M src/www/soap/svn/index.php +2 −3 Go to diff View file
A tests/phpunit/common/Project/DelegatedUserAccessForProjectTest.php +50 −0 Go to diff View file
M tests/phpunit/common/Project/ProjectAccessCheckerTest.php +59 −20 Go to diff View file
M tests/simpletest/common/mail/MailFilterTest.php +30 −19 Go to diff View file