Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Enable back controls when comment couldn't be saved

Download Browse

part of part of story #31151 Edit the description comment in text only When an error occured while saving a comment or the description comment, the controls are still disabled, preventing the user to have a chance to fix the error and to submit again. Now when an error occures, we reset is_being_submitted back to false in the form presenters, making the buttons enabled again. How to test: - Throw RestExceptions in PullRequestsResource l.731, l.913 and l.1143 - Edit the description comment and submit --> The error modal opens --> The [Cancel] and the [Save] buttons are not disabled anymore - Create a reply to an existing comment --> The error modal opens --> The [Cancel] and the [Reply] buttons are not disabled anymore - Write a global comment and submit it --> The error modal opens --> The [Comment] button is not disabled anymore Change-Id: I6527097254ca8d65788141738a41709955b072c7

+117 −25
Thomas Gorka (tgorka) 2023-03-20 14:42
Thomas Gorka (tgorka) 2023-03-21 10:59
52c4f34578efbb4a138216c79deb828835879642
f8c2a6a0eca9e99d2468a48a5790229bab4c203b
git #tuleap/stable/52c4f34578efbb4a138216c79deb828835879642

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentController.test.ts +7 −2 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentController.ts +4 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/ReplyCommentFormPresenter.test.ts +8 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/ReplyCommentFormPresenter.ts +4 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentController.test.ts +9 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentController.ts +11 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentFormPresenter.test.ts +24 −7 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentFormPresenter.ts +6 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/NewCommentFormController.test.ts +12 −2 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/NewCommentFormController.ts +9 −6 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/NewCommentFormPresenter.test.ts +19 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/NewCommentFormPresenter.ts +4 −0 Go to diff View file