Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Turn ComparisonType into a string-backed enum

Download Browse

Part of story #36833 search on semantics and always there fields even if not defined No functional change. CI should be happy. Why ? It allows us to reuse the operator strings that were previously defined in the ComparisonCheckers. We can simplify match expressions and use `default`. Change-Id: Ia494d922a6cc3ffb1a56f46b19cb8580cf2139cd

+21 −61
Joris MASSON (jmasson) 2024-03-26 14:41
Joris MASSON (jmasson) 2024-03-26 14:50
530b11d034dd29610002904f97bec5fe9a4c618a
31eccbc8c90bb218bc7f5183c01317dc81061501
git #tuleap/stable/530b11d034dd29610002904f97bec5fe9a4c618a

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/AssignedToChecker.php +2 −7 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/StatusChecker.php +1 −7 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/TextSemanticChecker.php +1 −7 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/ComparisonType.php +10 −10 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Date/DateFieldChecker.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/File/FileFieldChecker.php +1 −7 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FloatFields/FloatFieldChecker.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Integer/IntegerFieldChecker.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ArtifactSubmitterChecker.php +1 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ListFieldChecker.php +1 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Text/TextFieldChecker.php +1 −7 Go to diff View file