Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class in CrossReferencePullRequestOrganizer.php

Download Browse

Use the dedicated class instead a god factory to retrieve a pull request by its id. No functionnal change expected, cross reference should still work as before Part of request #35473 Stop relying on the god PullRequest/Factory class to retrieve pull request Change-Id: Iae5458a0a970b90561a992f1afab9feaf4518d4f

+111 −181
Clarck Robinson (robinsoc) 2023-12-05 11:31
Clarck Robinson (robinsoc) 2023-12-11 16:47
533475cb69da1602d043a1bea4ccc1c27b783227
a5df5f2c7f44588fbf82d1dd8feb2ad3ee7d1fe2
git #tuleap/stable/533475cb69da1602d043a1bea4ccc1c27b783227

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Reference/CrossReferencePullRequestOrganizer.php +44 −79 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/Reference/CrossReferencePullRequestOrganizerTest.php +60 −101 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Builders/PullRequestTestBuilder.php +6 −0 Go to diff View file