Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Factorize header options for milestones

Download Browse

Code to build header options was duplicated between VirtualTopMilestoneController (aka top backlog) and MilestoneController (regular milestones). In order to add more behavior later in this logic (in order to have a current context section in AD panes), this commit only refactors the duplication. This will avoid a too big review. Part of story #16206: « + New » button, better contextualisation Change-Id: I4b1cd704be75841be72a485ba060c4adbf4d37a5

+182 −40
Nicolas Terray (nterray) 2020-11-23 11:53
Nicolas Terray (nterray) 2020-11-23 15:50
5530d8021f50c9c6a64daec4ad8eb8fdaf079837
03e30bd1d9e1df27be426bb17e67420ca20c08f4
git #tuleap/stable/5530d8021f50c9c6a64daec4ad8eb8fdaf079837

Modified Files

Side by side diff
Inline diff
Name
A plugins/agiledashboard/include/AgileDashboard/Milestone/HeaderOptionsProvider.php +55 −0 Go to diff View file
M plugins/agiledashboard/include/AgileDashboardRouterBuilder.php +3 −1 Go to diff View file
M plugins/agiledashboard/include/Planning/MilestoneController.class.php +11 −17 Go to diff View file
M plugins/agiledashboard/include/Planning/MilestoneControllerFactory.class.php +13 −4 Go to diff View file
M plugins/agiledashboard/include/Planning/VirtualTopMilestoneController.class.php +11 −16 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/HeaderOptionsProviderTest.php +85 −0 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneControllerTest.php +4 −2 Go to diff View file