Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: title and description should be patchable individually

Download Browse

part of story #31151 Edit the description comment in text only When we want to update the pull-request title or description, we need to update both at the same time. We should be able to update them individually. Currently, there is a bug in pullreqsuest-overview where the title or the description is reset if you update the title or the description in the meantime. With this fix, it is now possible to update them individually. How to test: - In the angular app, open the update modal and update both the title and the description - submit --> They both have been updated within the same PATCH request - In the vue overview, update the title - Update the description - Refresh the page --> The title is still the new one - Update the title once again - Refresh the page --> The description hasn't been reset Change-Id: I5f244fadae83e9a1b65c0b1968884f28b5c629c5

+44 −34
Thomas Gorka (tgorka) 2023-03-22 17:32
Thomas Gorka (tgorka) 2023-03-23 14:58
5740ef7ee3afaba2384bba9a72df7cfd88c9aa30
b29accc3348c04a4dd69c6d9743c85a4fad89dca
git #tuleap/stable/5740ef7ee3afaba2384bba9a72df7cfd88c9aa30

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Dao.php +12 −4 Go to diff View file
M plugins/pullrequest/include/PullRequest/Factory.php +10 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +22 −13 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentFormPresenter.test.ts +0 −5 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentFormPresenter.ts +0 −2 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentPresenter.test.ts +0 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentPresenter.ts +0 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentSaver.test.ts +0 −2 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionCommentSaver.ts +0 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/DescriptionCommentPresenterBuilder.test.ts +0 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/DescriptionCommentPresenterBuilder.ts +0 −1 Go to diff View file