Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove dependency on GitPHP\Commit for CrossReferenceGitEnhancer

Download Browse

This is a refactoring. No functional changes are expected. CrossReferenceGitEnhancer is using GitPHP\Commit and GitRepository only to retrieve a CommitDetails. Instead we can pass directly the CommitDetails. This will help for future refactoring in order to reduce the number of sql queries to retrieve the contributors of referenced commits. Part of story #17180: take into account gitlab commits Change-Id: Ia5d88033afd02afe1278c644d32d0564cbeef61b

+102 −112
Nicolas Terray (nterray) 2021-01-05 16:25
Nicolas Terray (nterray) 2021-01-05 16:25
5746dbd03c35e29380154c34aeb805c0b2c13a72
651d6b0a66c88bb02d33eb0789a9a188b8accb3c
git #tuleap/stable/5746dbd03c35e29380154c34aeb805c0b2c13a72

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git/Reference/CrossReferenceGitEnhancer.php +3 −14 Go to diff View file
M plugins/git/include/Git/Reference/CrossReferenceGitOrganizer.php +10 −3 Go to diff View file
M plugins/git/include/gitPlugin.php +5 −5 Go to diff View file
M plugins/git/tests/unit/Git/Reference/CrossReferenceGitEnhancerTest.php +29 −76 Go to diff View file
M plugins/git/tests/unit/Git/Reference/CrossReferenceGitOrganizerTest.php +55 −14 Go to diff View file