Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: More precise type test

Download Browse

No functional change. CI should be happy. orElse() can create union types from None and Some cases of Option, the "type" tests should verify that. orElse() also returns a different Option instance. I have a feeling that returning the same instance only in this case will lead to bugs later. For example, andThen() returns a new instance. They should be symmetric. We should not hold onto intermediary option references anyway, they are meant to be chained or used. part of story #35104: Milestones below Backlog Change-Id: I4a82447cccb688b890717dd628dc96ab0197798e

+7 −8
Joris MASSON (jmasson) 2023-12-28 10:00
Joris MASSON (jmasson) 2023-12-28 10:10
589343f98f2d6adeb4df887ee98e24181a460cb7
a80176b5b2c6c4d9077a2b67fb849a9ee1c81d90
git #tuleap/stable/589343f98f2d6adeb4df887ee98e24181a460cb7

Modified Files

Side by side diff
Inline diff
Name
M src/common/Option/Option.php +1 −1 Go to diff View file
M tests/unit/common/Option/OptionTest.php +1 −2 Go to diff View file
M tests/unit/common/Option/TypeTest.php +5 −5 Go to diff View file