stable
Clone or download
Read-only
Those to arguments always work together and $duplication_type depends on the content of $ugroup_mapping plus downstream code does verification stuff on $ugroup_mapping while $duplication_type already carry this information. This is a good opportunity to have one object to group the two parameters and to introduce Enum to constraint the type of duplication. Part of request #30411 Project created from DB templates doesn't keep notification configuration Change-Id: I704ae6f7cc6b1ae687c19e21bdca676eff0f35d1
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElementFactory.php | +1 | −2 | Go to diff View file |
| A | plugins/tracker/include/Tracker/TrackerDuplicationType.php | +31 | −0 | Go to diff View file |
| A | plugins/tracker/include/Tracker/TrackerDuplicationUserGroupMapping.php | +88 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/TrackerFactory.class.php | +9 | −30 | Go to diff View file |
| M | plugins/tracker/include/Tracker/UgroupMappingBuilder.class.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/Condition/CommentNotEmpty/Factory.class.php | +0 | −6 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/Condition/FieldNotEmpty/Factory.class.php | +2 | −5 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/Condition/Permissions/Factory.class.php | +5 | −6 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/ConditionFactory.class.php | +5 | −7 | Go to diff View file |
| M | plugins/tracker/include/Workflow/TransitionFactory.class.php | +3 | −8 | Go to diff View file |
| M | plugins/tracker/include/Workflow/WorkflowFactory.class.php | +3 | −7 | Go to diff View file |
| M | plugins/tracker/tests/unit/Workflow/Transition/Condition/FieldNotEmpty/Workflow_Transition_Condition_FieldNotEmpty_FactoryTest.php | +1 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Workflow/Transition/Condition/Permissions/Workflow_Transition_Condition_Permissions_FactoryTest.php | +6 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Workflow/Transition/Workflow_Transition_ConditionFactoryTest.php | +7 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Workflow/TransitionFactoryTest.php | +6 | −4 | Go to diff View file |
| M | src/common/dao/PermissionsDao.class.php | +15 | −25 | Go to diff View file |
| M | src/common/permission/PermissionsManager.class.php | +8 | −8 | Go to diff View file |
| M | tests/unit/common/permission/PermissionsManagerTest.php | +26 | −16 | Go to diff View file |