stable
Clone or download
request #9230 Artifact API doesn't follow RFC
* The "Last-Modified" header is sent with ISO8601 format while RFC1123 is a MUST according to [1]. This breaks Apache 2.4 + FastCGI / php-fpm that goes nuts with last-modified not RFC compliant. * The return code for POST /artifacts/ returns 302, whereas it should be 201 according to [2]. This breaks nginx18 + FastCGI / php-fpm + guzzle for tests that goes nuts because there is a redirect after a POST * The "Location:" header is used to redirect according to [3]. This is a problem as it's systematicaly used by GET /artifact/:id (ie we force a redirect that is not necessary). In worst cases, that might lead to infinite loops. Bonux: align all POST to 201 [1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3.1 [2] https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html [3] https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30 Change-Id: I5ddb3efe36e45736745398853ad18f73f3a74bd8
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/Kanban/KanbanResource.php | +1 | −2 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneResource.class.php | +1 | −0 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/ArtifactTemporaryFilesResource.class.php | +1 | −0 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/ArtifactsResource.class.php | +1 | −2 | Go to diff View file |
| M | plugins/tracker/tests/rest/XML/ArtifactTest.php | +3 | −3 | Go to diff View file |
| M | src/common/REST/Header.class.php | +18 | −1 | Go to diff View file |
| M | src/common/Token/REST/v1/TokenResource.class.php | +1 | −0 | Go to diff View file |
| M | tests/rest/ArtifactFilesTest.php | +2 | −2 | Go to diff View file |
| M | tests/rest/ArtifactsTest.php | +3 | −3 | Go to diff View file |
| M | tests/rest/MilestoneBacklogTest.php | +1 | −1 | Go to diff View file |