Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Contextualize modal for adding a Azure AD based provider

Download Browse

The existing modal was still using the same terms than the creation for providers following OIDC standards when it should be clear the creation is about Azure AD. Also a lot of HTML elements were re-using the same IDs which is allowed, this contribution make sure IDs are no re-used between contexts. For now, the creation modal for a new Azure AD provider is only visible when the feature flag open_id_azure_option is set to 1. Part of request #12832: Support Azure AD as an OpenID Connect provider Change-Id: Ib3d6354006ae6e382a65a96bf6208af3a53d23eb

+239 −157
Thomas Gerbet (tgerbet) 2019-12-04 16:09
Thomas Gerbet (tgerbet) 2019-12-06 14:11
5eb6ecaac85dc0927bb80542f02b45f2ab8471e7
9f82e7334b69841fd124dfda2976b35147724bd0
git #tuleap/stable/5eb6ecaac85dc0927bb80542f02b45f2ab8471e7

Modified Files

Side by side diff
Inline diff
Name
M plugins/admindelegation/templates/modal-add-permission.mustache +2 −2 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Administration/Presenter.php +0 −10 Go to diff View file
M plugins/openidconnectclient/include/openidconnectclientPlugin.php +0 −1 Go to diff View file
M plugins/openidconnectclient/site-content/fr_FR/LC_MESSAGES/tuleap-openidconnectclient.po +3 −0 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers-azure-data.mustache +1 −1 Go to diff View file
D plugins/openidconnectclient/templates/administration-providers-create-form-begining.mustache +0 −39 Go to diff View file
D plugins/openidconnectclient/templates/administration-providers-create-form-ending.mustache +0 −56 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers-modal-create-azure.mustache +100 −8 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers-modal-create-generic.mustache +98 −7 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers-modal-delete.mustache +1 −1 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers-modal-update.mustache +10 −11 Go to diff View file
M plugins/openidconnectclient/templates/administration-providers.mustache +4 −6 Go to diff View file
M plugins/openidconnectclient/themes/BurningParrot/css/includes/_provider-admin-modal.scss +13 −10 Go to diff View file
M plugins/openidconnectclient/www/scripts/open-id-connect-client.js +7 −5 Go to diff View file