Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: do not pass unneeded parameters to visitors

Download Browse

This is a part of story #8858 query tracker with expressions No functional changes. PHP does not let us to have both proper Parameters and Visitor inheritance. Therefore we remove the contract definition in the Visitor so that we can vary the parameters given to each visitor. That way we do not need to pass not needed parameters to everyone. However this means that every time we create a visitor, we will need to guess the needed functions to parse the tree, but we think that it is the best wow as of today given the PHP limitations. Change-Id: I46475a95fedbaa88a827df186fe55f26a1462ad6

+252 −84
Nicolas Terray (nterray) 2017-01-02 15:21
Nicolas Terray (nterray) 2017-01-02 17:27
5f340b63d9917313ee59a2229d1f33413468422c
5db4e7fa39c929d1884a556d5af0db6131c8e832
git #tuleap/stable/5f340b63d9917313ee59a2229d1f33413468422c

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/AndExpression.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/AndOperand.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Comparison.php +3 −3 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/DepthValidatorParameters.php +24 −0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/DepthValidator.php Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/InvalidFieldsCollectorParameters.php +58 −0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Collector.php Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/OrExpression.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/OrOperand.php +4 −4 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/QueryBuilderParameters.php +43 −0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/QueryBuilder.php Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Visitable.php +25 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Visitor.php +1 −13 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/VisitorParameters.php +24 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +17 −17 Go to diff View file
M plugins/tracker/include/autoload.php +10 −5 Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/DepthValidatorTest.php +3 −3 Go to diff View file
R plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/CollectorTest.php Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/QueryBuilderTest.php +28 −27 Go to diff View file