stable
Clone or download
Read-only
refactor: request #39344 DatabaseUUIDFactory::buildUUIDFromHexadecimalString returns an Option<UUID>
It currently throws when the UUID cannot be decoded. This design will likely lead to the possibility for end-users to generate crashes by providing an invalid string. This is not desirable. An Option forces the developer to make an explicit decision about it. As the decision is likely to be "do nothing" like when the provided ID does not exist in the DB, an Option seems more suitable than Ok|Err. No fonctional changes expected. Change-Id: I67e399a912f01bdfa524cc7b7efa16520f01f8bd
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/artidoc/include/Artidoc/Document/Section/Identifier/InvalidSectionIdentifierStringException.php | +2 | −2 | Go to diff View file |
| M | plugins/artidoc/include/Artidoc/Document/Section/Identifier/SectionIdentifierFactory.php | +6 | −7 | Go to diff View file |
| M | plugins/bugzilla_reference/include/Bugzilla/Reference/Dao.php | +62 | −64 | Go to diff View file |
| M | plugins/fts_meilisearch/include/Index/MeilisearchMetadataDAO.php | +13 | −2 | Go to diff View file |
| M | plugins/pdftemplate/include/PdfTemplate/Image/Identifier/InvalidPdfTemplateImageIdentifierStringException.php | +2 | −2 | Go to diff View file |
| M | plugins/pdftemplate/include/PdfTemplate/Image/Identifier/PdfTemplateImageIdentifierFactory.php | +5 | −6 | Go to diff View file |
| M | src/common/DB/DatabaseUUIDFactory.php | +4 | −2 | Go to diff View file |
| M | src/common/DB/DatabaseUUIDV7Factory.php | +7 | −3 | Go to diff View file |
| M | src/common/Export/Pdf/Template/Identifier/InvalidPdfTemplateIdentifierStringException.php | +2 | −2 | Go to diff View file |
| M | src/common/Export/Pdf/Template/Identifier/PdfTemplateIdentifierFactory.php | +5 | −6 | Go to diff View file |