stable
Clone or download
Read-only
In the interface we have the capacity to install/uninstall and enable/disable a plugin. However in the code, for enable/disable we have many terms to describe the same concept: * enable * avail * available * activate Furthermore the interface have a dedicated view for uninstalled plugins which is labelled "Available plugins". This does not help at all. The proposal is to use enable/disable for plugin activation. To ease the refactoring, I took the opportunity to add more typing in PluginManager/PluginFactory. No functional changes, you can still install/uninstall, enable/disable, and `tuleap plugin:install` plugins. Note: `tools/utils/admin/activate_plugin.php` was marked as deprecated 13 months ago, it's time to remove it. Note: Web spaces and CGI are things of the past, no need to mention them when disabling a plugin. Note: In the db, the column `available` of the table `plugin` is kept as is to not break future `git bisect`. Closes request #27165: Uniform naming to enable/disable plugin Change-Id: I666ddcd09875133a1f369338c6a67f8e8d71d44b
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboardRouterBuilder.php | +1 | −0 | Go to diff View file |
| M | plugins/cardwall/include/cardwallPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/create_test_env/include/CreateTestEnv/REST/CreateTestEnvResource.php | +4 | −1 | Go to diff View file |
| M | plugins/docman/include/REST/v1/DocmanEmbeddedFilesResource.php | +2 | −1 | Go to diff View file |
| M | plugins/docman/include/REST/v1/DocmanEmptyDocumentsResource.php | +2 | −1 | Go to diff View file |
| M | plugins/docman/include/REST/v1/Folders/DocmanItemCreatorBuilder.php | +2 | −1 | Go to diff View file |
| M | plugins/docman/include/REST/v1/ProjectMetadataResource.php | +1 | −0 | Go to diff View file |
| M | plugins/docman/include/soap.php | +2 | −1 | Go to diff View file |
| M | plugins/docman/tests/rest/init_test_data.php | +1 | −1 | Go to diff View file |
| M | plugins/dynamic_credentials/include/REST/DynamicCredentialsResource.php | +1 | −0 | Go to diff View file |
| M | plugins/dynamic_credentials/tests/rest/DynamicCredentialsPluginRESTInitializer.php | +1 | −1 | Go to diff View file |
| M | plugins/forumml/bin/mail2dbng.php | +1 | −1 | Go to diff View file |
| M | plugins/git/bin/gl-admin-housekeeping.php | +2 | −1 | Go to diff View file |
| M | plugins/git/bin/gl-rename-project.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git/Repository/GitRepositoryHeaderDisplayerBuilder.php | +1 | −0 | Go to diff View file |
| M | plugins/git/include/Git_Backend_Gitolite.class.php | +4 | −2 | Go to diff View file |
| M | plugins/git/include/Git_Widget_ProjectPushes.class.php | +4 | −3 | Go to diff View file |
| M | plugins/git/include/REST/v1/GitProjectResource.php | +2 | −1 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabBranchResource.php | +4 | −3 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabMergeRequestResource.php | +4 | −3 | Go to diff View file |
| M | plugins/gitlab/tests/rest/GitLabDataBuilder.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlfs/bin/git-lfs-authenticate.php | +3 | −1 | Go to diff View file |
| M | plugins/gitlfs/include/gitlfsPlugin.php | +4 | −3 | Go to diff View file |
| M | plugins/graphontrackersv5/include/graphontrackersv5Plugin.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/bin/convertSvnToLdap.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/bin/ldap_feed_user.php | +2 | −2 | Go to diff View file |
| M | plugins/ldap/bin/ldap_sync.php | +2 | −2 | Go to diff View file |
| M | plugins/ldap/bin/registerUser.php | +2 | −2 | Go to diff View file |
| M | plugins/mediawiki/bin/clean-unused-db.php | +5 | −1 | Go to diff View file |
| M | plugins/mediawiki/fusionforge/compat/forge_get_config.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/www/LocalSettings.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/www/forge_admin.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/www/images.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/www/skins/Tuleap123/Tuleap123.php | +1 | −1 | Go to diff View file |
| M | plugins/pluginsadministration/include/PluginsAdministration.class.php | +4 | −4 | Go to diff View file |
| M | plugins/pluginsadministration/include/PluginsAdministrationActions.class.php | +18 | −17 | Go to diff View file |
| M | plugins/pluginsadministration/include/PluginsAdministrationViews.class.php | +20 | −11 | Go to diff View file |
| M | plugins/pluginsadministration/include/Presenter/installedPluginsPresenter.class.php | +0 | −5 | Go to diff View file |
| M | plugins/pluginsadministration/site-content/fr_FR/LC_MESSAGES/tuleap-pluginsadministration.po | +22 | −24 | Go to diff View file |
| M | plugins/pluginsadministration/site-content/pt_BR/LC_MESSAGES/tuleap-pluginsadministration.po | +15 | −16 | Go to diff View file |
| M | plugins/pluginsadministration/templates/enable-disable-plugin-switch.mustache | +2 | −2 | Go to diff View file |
| M | plugins/pluginsadministration/templates/installed-plugins.mustache | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/bin/parse_xferlog.php | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/www/explorer.php | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/www/index.php | +1 | −1 | Go to diff View file |
| M | plugins/project_ownership/tests/rest/init_test_data.php | +1 | −1 | Go to diff View file |
| M | plugins/projectmilestones/include/projectmilestonesPlugin.php | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/REST/v1/RepositoryResource.php | +4 | −1 | Go to diff View file |
| M | plugins/pullrequest/include/pullrequestPlugin.php | +3 | −0 | Go to diff View file |
| M | plugins/pullrequest/tests/rest/PullRequestDataBuilder.php | +2 | −1 | Go to diff View file |
| M | plugins/statistics/include/CSV/CSVBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/statistics/include/Statistics_DiskUsageHtml.class.php | +5 | −3 | Go to diff View file |
| M | plugins/statistics/include/Statistics_DiskUsageManager.class.php | +3 | −1 | Go to diff View file |
| M | plugins/statistics/www/data_export.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/disk_usage.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/disk_usage_graph.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/frequence_stat_graph.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/index.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/project_cumulativeDiskUsage_graph.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/project_over_quota.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/project_quota.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/project_stat.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/project_stat_graph.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/scm_stats.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/services_usage.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/soap/index.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/soap/wsdl.php | +1 | −1 | Go to diff View file |
| M | plugins/statistics/www/usage_stat.php | +1 | −1 | Go to diff View file |
| M | plugins/testplan/tests/rest/init_test_data.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/ServiceTracker.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Admin/ArtifactsDeletion/ArtifactsDeletionConfigController.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/WebDAVTree.class.php | +0 | −41 | Go to diff View file |
| M | plugins/webdav/include/WebDAVUtils.class.php | +8 | −27 | Go to diff View file |
| M | src/common/DB/Compat/Legacy2018/CompatPDODataAccessResult.php | +6 | −16 | Go to diff View file |
| M | src/common/Plugin/Plugin.php | +2 | −37 | Go to diff View file |
| M | src/common/Plugin/PluginDependencySolver.php | +6 | −8 | Go to diff View file |
| M | src/common/Plugin/PluginFactory.php | +45 | −79 | Go to diff View file |
| M | src/common/Plugin/PluginInstallCommand.php | +1 | −1 | Go to diff View file |
| M | src/common/Plugin/PluginLoader.php | +1 | −1 | Go to diff View file |
| M | src/common/Plugin/PluginManager.php | +37 | −34 | Go to diff View file |
| M | src/common/Project/XML/ConsistencyChecker.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/XML/ServiceEnableForXmlImportRetriever.php | +1 | −1 | Go to diff View file |
| M | src/common/dao/PluginDao.class.php | +31 | −23 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginDependencySolverTest.php | +2 | −2 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginFactoryTest.php | +17 | −33 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginLoaderTest.php | +4 | −4 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginManagerTest.php | +9 | −10 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginTest.php | +5 | −5 | Go to diff View file |
| M | tests/unit/common/Project/REST/v1/RestProjectCreatorTest.php | +1 | −1 | Go to diff View file |
| M | tests/unit/common/Project/XML/ConsistencyCheckerTest.php | +3 | −3 | Go to diff View file |
| M | tests/unit/common/Project/XML/ServiceEnableForXmlImportRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | tests/unit/common/Request/FrontRouterTest.php | +1 | −1 | Go to diff View file |
| M | tools/stats/generate.php | +3 | −3 | Go to diff View file |
| D | tools/utils/admin/activate_plugin.php | +0 | −32 | Go to diff View file |