Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Warn project admin when a gitlab_commit reference previously exists

Download Browse

part of: story #17180 take into account gitlab commits How to test: - Run `make dev-clear-cache` - Disable the GitLab plugin - Create a project reference named gitlab_commit - Enable the GitLab plugin again - Go back to the main view of the project references admin --> There is a warning sent by the GitLab plugin - Delete the reference by clicking on the trash icon at the end of the table row --> The warning has disappeared Change-Id: I0d1bb3d602998dd7ce1b57ba928b6300e662d4fe

+266 −12
Thomas Gorka (tgorka) 2020-12-17 17:06
Thomas Gorka (tgorka) 2020-12-21 10:15
600f9c2a56cd1c9e0eb15006ab033c5d5771241a
65cfb3b9f99874eae3ec1104f13d730dee84aff9
git #tuleap/stable/600f9c2a56cd1c9e0eb15006ab033c5d5771241a

Modified Files

Side by side diff
Inline diff
Name
A plugins/gitlab/include/EventsHandlers/ReferenceAdministrationWarningsCollectorEventHandler.php +47 −0 Go to diff View file
M plugins/gitlab/include/Reference/GitlabCommitReference.php +3 −1 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +12 −3 Go to diff View file
M plugins/gitlab/site-content/fr_FR/LC_MESSAGES/tuleap-gitlab.po +13 −0 Go to diff View file
A plugins/gitlab/tests/unit/EventsHandlers/ReferenceAdministrationWarningsCollectorEventHandlerTest.php +87 −0 Go to diff View file
M src/common/Project/Admin/Reference/ReferenceAdministrationViews.php +32 −6 Go to diff View file
A src/common/Project/Admin/Reference/ReferenceAdministrationWarningsCollectorEvent.php +68 −0 Go to diff View file
M src/common/reference/ReferenceManager.class.php +4 −2 Go to diff View file