Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat(forge-config): list keys that cannot be modified

Download Browse

Until now, ConfigListCommand was only showing variables that can be modified with ConfigSetCommand. However, in a previous commit we introduced a new configuration variable controlled by #[ConfigKey] attribute but this attribute cannot be modified by ConfigSet. Unless you are mad or a java developer, you are unlikely to store the info to access your database INSIDE the very same database. In the Future, ConfigListCommand will list all possible parameters and ConfigSetCommand will allow to set most of those parameters. As some of those parameters should not be set in the DB (like DB parameters) or should not be modifiable with the unified API (like the number of license in an external plugin) the #[CannotBeModified] attribute is introduced. Part-of: story #22708 flexibility in the management of Tuleap Configuration Change-Id: Ia9a32217148f13babb54523545119977d6feeb49

+176 −34
Manuel Vacelet (vaceletm) 2021-10-05 16:44
Manuel Vacelet (vaceletm) 2021-10-20 11:07
60188bef0f63bd880b81fbaa617d1a1a5b65fc46
c807e962ed25c185126d612d4113d2047185ea88
git #tuleap/stable/60188bef0f63bd880b81fbaa617d1a1a5b65fc46

Modified Files

Side by side diff
Inline diff
Name
M src/common/CLI/Command/ConfigListCommand.php +5 −11 Go to diff View file
M src/common/CLI/Events/GetWhitelistedKeys.php +34 −11 Go to diff View file
A src/common/Config/ConfigCannotBeModified.php +30 −0 Go to diff View file
A src/common/Config/ConfigKeyMetadata.php +34 −0 Go to diff View file
M src/common/Config/ConfigSet.php +1 −1 Go to diff View file
M src/common/Config/InvalidConfigKeyException.php +1 −1 Go to diff View file
M src/common/DB/DBConfig.php +2 −0 Go to diff View file
M tests/unit/common/CLI/Events/GetWhitelistedKeysTest.php +69 −10 Go to diff View file