Part of story #38627: Choice of a new Rich Text Editor Note: In order to allow the editor to have a structure grouping the section title and the section description, we had to introduce the concept of structure blocks. These blocks hold the content of the editor, and cannot be replaced, wrapped or modified. This is why they are explicitly ignored in some places of the prose-mirror-editor code. For instance: - In the lists detection code. - In the "wrap in blockquote" code. - In the drop file feature. Regarding the drop-file plugin, we had to slightly rework the way image nodes were created inside the editor. Before this contribution, they were savagely inserted by replacing the current selection. However, this way of inserting the image node wasn't great, because the image was actually inserted at the last place you clicked, and not where the drop cursor is when the drop event fires. In order to compute the insertion point, we now retrieve the position of the node inside the state where the image has been dropped. Moreover, the `insertPoint` function used to get the final position of the future image node takes in consideration the current schema, so it forbids the drop in the title node and the section node. Please note that the dropCursor plugins does not really work well. We couldn't prevent it to display the drop cursor on the artidoc-section element yet. It could be sometimes misleading for the user that it seems possible to drop an image, while it is not possible. We'll try to fix this behavior in a next contribution. How to test: - Edit the title and the description - Click on cancel --> The content has been reset - Edit the title and the description - Click on Save --> The content has been saved You can still: - Apply styles on the content (basically all the toolbar features work) - Drop images in the editor (where allowed, see explanations above) - Artidoc Cypress tests should pass successfully. Co-authored-by: Clarisse Deschamps <clarisse.deschamps@enalean.com> Co-authored-by: Thomas Gorka <thomas.gorka@enalean.com> Change-Id: I871c975537d8d333392c25b7c54b31c4f5d53d15

+547 −346

Author

Clarisse Deschamps (cdeschamps) 2024-10-25 16:25

Committer

Clarisse Deschamps (cdeschamps) 2024-11-04 17:22

Hash 6041a0b1a9dc5b210bfd8f6c511ed3bb3bc0a44c

Parent c000b1869db983ece4bedddb6f8edc254437a027

Reference git #tuleap/stable/6041a0b1a9dc5b210bfd8f6c511ed3bb3bc0a44c