stable
Clone or download
Read-only
request #11209 TTM homepage loads all closed campaigns
How to test: - Given open and closed campaigns, when you browse the campaign list, the closed campaigns are no longer loaded at init. - You must click the "Load closed campaigns" button to actually load them. - Check that the empty state messages are still correct - When there aren't any open campaigns, the user can load closed campaigns - After loading closed campaigns, given there are no campaigns at all, then the "Hide" button won't be shown - Filtering should still work and will no longer show duplicates. I took the opportunity to remove all $scope dependency and use 'ctrlAs'. Change-Id: I42643ccefdd26c96c13ed43d15b23d1641ba1feb
Modified Files
Name | ||||
---|---|---|---|---|
M | www/scripts/angular/src/app/app-filter.js | +3 | −1 | Go to diff View file |
M | www/scripts/angular/src/app/app-filter.spec.js | +7 | −0 | Go to diff View file |
M | www/scripts/angular/src/app/campaign/campaign-config.js | +1 | −0 | Go to diff View file |
M | www/scripts/angular/src/app/campaign/campaign-list-controller.js | +74 | −64 | Go to diff View file |
M | www/scripts/angular/src/app/campaign/campaign-list-controller.spec.js | +187 | −87 | Go to diff View file |
M | www/scripts/angular/src/app/campaign/campaign-list.tpl.html | +41 | −13 | Go to diff View file |