Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: centralize project access check for xrefs

Download Browse

Until now, each plugin is responsible to check if the reference to display is belonging to a project the user can access. This has two drawbacks: * We duplicate code * We don't enforce this check, one new plugin could omit this check Now, everytime a cross reference is organized in a nature, the project access is automatically checked. No functional changes. Part of story #17180 take into account gitlab commits Change-Id: Iba697982c05706de59303b1e7f0e78a5199d7a7f

+187 −390
Nicolas Terray (nterray) 2020-12-23 16:08
Nicolas Terray (nterray) 2020-12-23 16:20
62059f9e2e8eb8f7e06ed1caf0e7449ffd8c09fc
4bd2a0b6481b98e98110e3b58a3f664fefe8be74
git #tuleap/stable/62059f9e2e8eb8f7e06ed1caf0e7449ffd8c09fc

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/Reference/CrossReferenceDocmanOrganizer.php +1 −13 Go to diff View file
M plugins/docman/include/docmanPlugin.php +0 −5 Go to diff View file
M plugins/docman/tests/unit/Reference/CrossReferenceDocmanOrganizerTest.php +2 −72 Go to diff View file
M plugins/git/include/Git/Reference/CrossReferenceGitOrganizer.php +4 −16 Go to diff View file
M plugins/git/include/gitPlugin.php +0 −5 Go to diff View file
M plugins/git/tests/unit/Git/Reference/CrossReferenceGitOrganizerTest.php +3 −68 Go to diff View file
M plugins/gitlab/include/Reference/GitlabCrossReferenceOrganizer.php +2 −15 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +0 −7 Go to diff View file
M plugins/gitlab/tests/unit/Reference/GitlabCrossReferenceOrganizerTest.php +2 −64 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/CrossReference/CrossReferenceArtifactOrganizer.php +11 −18 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_CrossReferences.php +8 −1 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +0 −5 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/CrossReference/CrossReferenceArtifactOrganizerTest.php +2 −62 Go to diff View file
M src/common/Reference/CrossReferenceByDirectionPresenterBuilder.php +17 −5 Go to diff View file
M src/common/Reference/CrossReferenceByNatureOrganizer.php +40 −17 Go to diff View file
M tests/unit/common/Reference/CrossReferenceByDirectionPresenterBuilderTest.php +2 −0 Go to diff View file
M tests/unit/common/Reference/CrossReferenceByNatureOrganizerTest.php +93 −17 Go to diff View file