Contrary to the original investigations, attributes for hook registrations is more simple than with previous design. Originally string based events didn't had the issue of conditional load because strings always existed. However, when we introduced const based events, it was a pain because as base classes might not be loaded, the const might not be defined. So we worked around with the good old plain constant and check with `defined`. When we moved to object based events, we kept the `if(defined())` strategy while there was a better option: rely on autoload + class existance check. For 2023 version of events, it's time to clean this up. For weak plugin to plugin dependencies (like statistics that can be there or not), the attribute will only register the hook if the event class actually exist (ie autoload tries to load it, if it fails then we don't hook on that). Plugin developers no longer have to worry about that. Part of: request #31113 Simplify hook listening for plugins Change-Id: I72ce12da7fdb92003426f1866361b38f55c69276

+187 −196

Author

Manuel Vacelet (vaceletm) 2023-03-07 08:24

Committer

Manuel Vacelet (vaceletm) 2023-03-08 09:32

Hash 62ae8e63a26217d3f55f43875280d9bfb4e88f39

Parent 828d4160e74305696e66d353158dde9946700205

Reference git #tuleap/stable/62ae8e63a26217d3f55f43875280d9bfb4e88f39