As of today, for plugins, listening to hooks is tedious, there is a lot of copy/paste and things are scattered at different places: * Usage of hooks must be declared in `getHooksAndCallbacks` * It's not easy to find the hook that correspond to a callback * There is a lot of repetition of the event: at hook declaration (`getHooksAndCallbacks`), at the name of the callback, at the first parameter name. Using attributes, greatly simplify that: * Declaration of hook listening callback is done at callback level (no more back & forth with top of the class) * Callback can be named diffrently from hook (psr1 compat, typo in hook name, more precise naming) * No need to repeat the Event name, the paramter of the hook is enough. In addition to that, this patch also brings the possibility to have `NAME` less events. That further reduce the boilerplate of Event declaration and make them PSR-14 compatible. Part of: request #31113 Simplify hook listening for plugins Change-Id: Ie85be50e430b1ca889b413f2d6ba601b5c4dbc10

+290 −25

Author

Manuel Vacelet (vaceletm) 2023-03-03 11:48

Committer

Manuel Vacelet (vaceletm) 2023-03-06 17:17

Hash 64be87d14c3321e7db954c0c0b9b0e7d9375a3ec

Parent e2ce6efa77a30b511fc5687c2552188514d20aec

Reference git #tuleap/stable/64be87d14c3321e7db954c0c0b9b0e7d9375a3ec