Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: popover elements not found when toolbar is disconnected

Download Browse

Part of story #38627: Choice of a new Rich Text Editor Context: The popovers of the link and the image buttons are moved to document.body right after the toolbar has been connected to the DOM (see git #tuleap/stable/002cb45ebe1d2abb3520efa3d31a3c397bfaacdc) and are moved back to the toolbar element when it is disconnected from the DOM. However, we never had a case where the toolbar was removed from the DOM, and thus never caught this issue. It was spotted while fixing artidoc's Cypress tests in which the error "Unable to find the popover element" error was logged twice in the tests logs. How to test: - Run the cypress tests of artidoc. --> There are no "Unable to find the popover element" errors anymore. Change-Id: I4769b50af3540dd4ed7ca6dca9fd89bdb33a426a

+7 −3
Thomas Gorka (tgorka) 2024-10-25 12:12
Thomas Gorka (tgorka) 2024-10-28 15:07
669670e9a57653486d4e0948ad91591be9fdbc2f
c78c867e0c664ba8d9cba255c350fe9af3d6d00b
git #tuleap/stable/669670e9a57653486d4e0948ad91591be9fdbc2f

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/common/connect-popover.ts +7 −3 Go to diff View file