part of request #24994 : Javascript error in Iterations planning How to test: - Go to a Program administration and erase custom labels for Iterations (set them to empty). - Go to the "Plan iterations" app - You should not see a console error complaining about the "length property of null". - You should see the default labels "Iterations" and "iteration" Notes: The frontend should not be responsible for defaulting the custom labels, it is more consistent to do it in the backend. We should never have allowed empty string values in labels database, they were supposed to be <null> when left empty. The assumption was that null values better express the different business case for "empty => default value" because we usually forget that strings variables can be empty. Dealing with both null values and empty strings is a burden. There are two paths we can take here: 1. forbid empty values and convert them to null 2. forbid null values and convert them to empty strings. I've chosen the first option because it does not require a forgeupgrade. IterationsDAO will return null labels instead of empty strings. NewIterationTrackerConfiguration will enforce null values for empty labels. Change-Id: Ia5900f296003aa4017daf350fc230ee4fa3e3c3f

+142 −56

Author

Joris MASSON (jmasson) 2022-01-12 16:22

Committer

Joris MASSON (jmasson) 2022-01-17 12:57

Hash 670539a425363949a15d5406f9e011e7a6f94073

Parent b23a783e81866dd09bc5adf23ea995e4e05591be

Reference git #tuleap/stable/670539a425363949a15d5406f9e011e7a6f94073