Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: key creation date storage

Download Browse

Part of story #31174 see my registered passkeys When we register a new passkey, its registration date is saved and then each time we use it, its last use is saved too. To do that, there is just default and on update rules in mysql table, problem : mysql timezone is not the same as use timezone. To fix that, database store a timestamp as an unsigned integer and not a datetime, and it's not the database who set these values but the php script. *Testing:* Assuming mysql timezone is UTC and yours is UTC+2, before the patch if your register a passkey at 11h, 9h will be displayed. Now it's 11h. Change-Id: I5365818b4dbffbf4cccb1169434fe81a6ac52150

+76 −15
Kevin Traini (ktraini) 2023-05-22 16:47
Kevin Traini (ktraini) 2023-05-23 14:54
675a0fffa20b19bc1ef69b47c39ee4426a909d5e
6fa015c3530db3883f50992acebc52443aad01e4
git #tuleap/stable/675a0fffa20b19bc1ef69b47c39ee4426a909d5e

Modified Files

Side by side diff
Inline diff
Name
M plugins/webauthn/include/WebAuthn/Controllers/AccountController.php +1 −1 Go to diff View file
M plugins/webauthn/include/WebAuthn/Controllers/AuthenticatorPresenter.php +10 −2 Go to diff View file
M src/common/WebAuthn/Source/WebAuthnCredentialSourceDao.php +17 −6 Go to diff View file
M src/db/mysql/database_structure.sql +2 −2 Go to diff View file
A src/db/mysql/updates/2023/202305191513_webauthn_created_at_type.php +41 −0 Go to diff View file
M tests/integration/tests/WebAuthn/Source/WebAuthnCredentialSourceDaoTest.php +2 −2 Go to diff View file
M tests/lib/Stubs/WebAuthn/WebAuthnCredentialSourceDaoStub.php +3 −2 Go to diff View file