Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactor: convert restrict modal to dedicated view

Download Browse

We need to switch to a full featured page instead of a modal for future developments, mostly due to the fact that we need to redirect to the same page, and preopening a modal is not the better way to do that. To test: Click on [restrict] button leads to a dedicated page. User can refresh the page. User can make changes to restrictions and submit. They are redirected to the same page. Click on [cancel] button leads to servers list. Implementation note: instead of using a dedicated routing library like Vue Router, we start small by using our own since our needs are quite limited. If needed we will switch later to Vue Router. Part of story #29981: restrict an OnlyOffice server to some projects only Change-Id: Ibaf8dba12843aa1013f5d0a2743b9a5a1cff4285

+418 −200
Nicolas Terray (nterray) 2023-01-09 17:07
Nicolas Terray (nterray) 2023-01-09 17:13
680a6815d4943b476369dae4a9d1c30d001c4952
297e88162455dba826839362569327b7a24661d7
git #tuleap/stable/680a6815d4943b476369dae4a9d1c30d001c4952

Modified Files

Side by side diff
Inline diff
Name
M plugins/onlyoffice/include/Administration/OnlyOfficeAdminSettingsPresenter.php +2 −0 Go to diff View file
M plugins/onlyoffice/include/Administration/OnlyOfficeRestrictAdminSettingsController.php +8 −2 Go to diff View file
M plugins/onlyoffice/include/Administration/OnlyOfficeServerPresenter.php +1 −1 Go to diff View file
M plugins/onlyoffice/include/onlyofficePlugin.php +1 −1 Go to diff View file
A plugins/onlyoffice/scripts/siteadmin/src/components/App.test.ts +186 −0 Go to diff View file
A plugins/onlyoffice/scripts/siteadmin/src/components/App.vue +52 −0 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/components/Servers/AddServerButton.vue +1 −1 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/components/Servers/DeleteServerButton.vue +1 −1 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/components/Servers/EditServerButton.vue +1 −1 Go to diff View file
R plugins/onlyoffice/scripts/siteadmin/src/components/ServersApp.vue Go to diff View file
R plugins/onlyoffice/scripts/siteadmin/src/components/Servers/RestrictServerModal.test.ts Go to diff View file
A plugins/onlyoffice/scripts/siteadmin/src/components/Servers/Restrict/RestrictServer.vue +150 −0 Go to diff View file
R plugins/onlyoffice/scripts/siteadmin/src/components/Servers/RestrictServerButton.vue Go to diff View file
D plugins/onlyoffice/scripts/siteadmin/src/components/Servers/RestrictServerModal.vue +0 −185 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/components/Servers/ServerRow.vue +2 −4 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/helpers/emitter.ts +0 −1 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/injection-keys.ts +2 −1 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/onlyoffice-siteadmin.ts +5 −2 Go to diff View file
M plugins/onlyoffice/scripts/siteadmin/src/type.ts +6 −0 Go to diff View file