stable

Clone or download

Read-only

Fix Psalm errors

Newly introduced annotation/types highlighted parts of the code that doesnt handle properly the return types. Fix them to have a clean build and a safe app. Part of story #13490 have a consistent management of project & groups members Change-Id: Iad992c72c4410ec944a7fc2ab37276a72e86a9c8

Modified Files

Name
M plugins/docman/include/PermissionsPerGroup/PermissionPerGroupDocmanServicePaneBuilder.php +1 −1 Go to diff View file
M plugins/git/include/GitXMLExporter.php +7 −2 Go to diff View file
M plugins/svn/include/SVN/PermissionsPerGroup/PermissionPerGroupSVNGlobalAdminPermissionCollection.php +1 −1 Go to diff View file
M plugins/svn/include/SVN/PermissionsPerGroup/PermissionPerGroupSVNServicePaneBuilder.php +2 −2 Go to diff View file
M plugins/tracker/include/PermissionsPerGroup/TrackerPermissionPerGroupPermissionRepresentationBuilder.php +3 −3 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind.class.php +7 −3 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Ugroups.class.php +11 −1 Go to diff View file
M plugins/tracker/include/Tracker/UgroupPermissionsGoldenRetriever.class.php +6 −4 Go to diff View file
M src/common/Project/Admin/PermissionPerGroup/PermissionPerGroupBuilder.php +12 −12 Go to diff View file
M src/common/Project/Admin/PermissionPerGroup/PermissionPerGroupUGroupRepresentationBuilder.php +5 −2 Go to diff View file
M src/common/Project/Admin/ProjectMembers/ProjectMembersController.php +20 −17 Go to diff View file
M src/common/Project/Admin/ProjectUGroup/UGroupListPresenterBuilder.php +4 −2 Go to diff View file
M src/common/Project/ProjectCreationTemplatePresenter.class.php +1 −1 Go to diff View file
M src/common/Project/ProjectXMLExporter.class.php +2 −2 Go to diff View file
M src/common/Project/UGroupManager.class.php +25 −3 Go to diff View file
A src/common/Project/UGroups/InvalidUGroupException.php +32 −0 Go to diff View file
M src/common/frs/PermissionsPerGroup/PermissionPerTypeExtractor.php +1 −1 Go to diff View file
M src/www/include/proj_email.php +21 −6 Go to diff View file
M tests/phpunit/common/Frs/PermissionsPerGroup/PermissionPerTypeExtractorTest.php +1 −4 Go to diff View file
M tests/phpunit/common/Project/ProjectXMLExporterTest.php +6 −5 Go to diff View file
M tests/phpunit/common/Project/ProjectXMLExporterWithSynchronizedUGroupsTest.php +4 −4 Go to diff View file