stable
Clone or download
part of story #24969 [modal] add and remove links without types No functional change expected. It's easier to handle modifications when we don't have to add another parameter to an 8-parameter method. Everything related to Changesets has been grouped in NewChangeset. Parameters related to post-creation actions have been grouped in PostCreationContext (since they are related to each other). Since we also needed a changeset_id to create a NewComment, another object has been introduced. CommentCreation is meant to be the "final stage", where we also substitute file URLs. NewComment is now an intermediate stage that holds raw comment data. I also took the opportunity to introduce a CommentFormatIdentifier class that should simplify format handling. Comparisons should be in that class, like isHTML (because HTML has special treatment). Change-Id: Ied1c6821ca81d2be6668444e5e74555ca2bb7ae7
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ChangesetAdder.php | +9 | −14 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ChangesetAdderTest.php | +42 | −40 | Go to diff View file |
| M | plugins/tracker/include/REST/Artifact/ArtifactUpdater.php | +12 | −8 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Artifact.php | +29 | −22 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Artifact/Changeset/Comment/CommentCreation.php | +98 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Changeset/Comment/CommentCreator.php | +2 | −2 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Artifact/Changeset/Comment/CommentFormatIdentifier.php | +64 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Changeset/Comment/NewComment.php | +13 | −56 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Artifact/Changeset/NewChangeset.php | +122 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.php | +41 | −105 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/PostCreationContext.php | +58 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/XMLImport.class.php | +11 | −6 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Tracker_Artifact_XMLImportTest.php | +49 | −17 | Go to diff View file |
| M | plugins/tracker/tests/unit/REST/Artifact/ArtifactUpdaterTest.php | +72 | −34 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/CommentCreationTest.php | +94 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/CommentCreatorTest.php | +60 | −43 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/CommentFormatIdentifierTest.php | +74 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/NewCommentTest.php | +26 | −42 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetCreatorTest.php | +18 | −17 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetTest.php | +103 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/PostCreationContextTest.php | +63 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/Tracker_ArtifactTest.php | +10 | −16 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/XmlImportTest.php | +169 | −236 | Go to diff View file |