Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Bind builder should not try to build its field by itself

Download Browse

part of story #10710 search on fields with duck typing No functional change. CI should be happy. Why? Mixing parameters meant for two different constructors should be avoided. It makes the bind builders too dependent upon the list field builder. They should instead ask the caller to give them a list field. The caller is free to build it however they want. I also took the opportunity to rename and move to namespaces. No need to keep repeating TrackerFormElement, this is part of the namespace. Change-Id: I4d6bf1b0bbb84789d2f1ee7faa885f3ccfdce0df

+173 −99
Joris MASSON (jmasson) 2024-02-28 09:29
Joris MASSON (jmasson) 2024-02-28 09:29
6bac1b569739441da9ba0406ba9274399fa42c2d
8c7eaa88aedc1b317fba49384dc9219e2c3b45b3
git #tuleap/stable/6bac1b569739441da9ba0406ba9274399fa42c2d

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/DuckTypedField/FieldTypeRetrieverWrapperTest.php +20 −19 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryBuilder/Field/FieldFromWhereBuilderTest.php +31 −27 Go to diff View file
M plugins/kanban/tests/unit/KanbanActionsCheckerTest.php +4 −4 Go to diff View file
R plugins/tracker/tests/unit/Builders/TrackerFormElementListStaticBindBuilder.php Go to diff View file
R plugins/tracker/tests/unit/Builders/TrackerFormElementListUserBindBuilder.php Go to diff View file
R plugins/tracker/tests/unit/Builders/TrackerFormElementListUserGroupBindBuilder.php Go to diff View file
R plugins/tracker/tests/unit/Builders/TrackerFormElementListFieldBuilder.php Go to diff View file
M plugins/tracker/tests/unit/REST/Artifact/ChangesetValue/FieldsDataFromValuesByFieldBuilderTest.php +3 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/AreListFieldsCompatibleVerifierTest.php +25 −10 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/DryRunDuckTypingFieldCollectorTest.php +5 −5 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/IsUserGroupListFieldVerifierTest.php +9 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/StaticListFieldVerifierTest.php +9 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/UserGroupOpenListFieldVerifierTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/UserListFieldVerifierTest.php +9 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/XML/Updater/BindValueForDuckTypingUpdaterTest.php +3 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/XML/Updater/MoveChangesetXMLDuckTypingUpdaterTest.php +52 −13 Go to diff View file
M plugins/tracker/tests/unit/Workflow/WorkflowTest.php +1 −1 Go to diff View file