stable
Clone or download
Baseline Domain should not have direct dependency on Tuleap's Project class. You can check that the number of errors raised by deptrac decrease with this change (From 108 to 70 "uncovered"). The remaining errors concern PFUser and will be managed in a dedicated changeset to not produce a too big review. make deptrac SEARCH_PATH=plugins/baseline/tests/deptrac/baseline_domain.yml With plugins/baseline/tests/deptrac/baseline_domain.yml: ``` use_relative_path_from_depfile: false paths: - ./plugins/baseline/include/ layers: - name: Domain collectors: - type: directory regex: plugins/baseline/include/Domain/.* ruleset: Domain: ~ ``` (This file will be added later to not break the CI) No functional changes. Part of story #26359: define dedicated baseline managers Change-Id: Iea2a1d61783c2115f357b7a237b24d816e88aa6e
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/baseline/include/Adapter/BaselineArtifactRepositoryAdapter.php | +4 | −4 | Go to diff View file |
| M | plugins/baseline/include/Adapter/BaselineRepositoryAdapter.php | +4 | −4 | Go to diff View file |
| M | plugins/baseline/include/Adapter/ComparisonRepositoryAdapter.php | +4 | −4 | Go to diff View file |
| A | plugins/baseline/include/Adapter/ProjectProxy.php | +49 | −0 | Go to diff View file |
| M | plugins/baseline/include/Adapter/ProjectRepositoryAdapter.php | +3 | −3 | Go to diff View file |
| M | plugins/baseline/include/Adapter/RoleAssignment.php | +4 | −4 | Go to diff View file |
| M | plugins/baseline/include/Adapter/RoleAssignmentRepositoryAdapter.php | +2 | −2 | Go to diff View file |
| M | plugins/baseline/include/Domain/Authorizations.php | +2 | −3 | Go to diff View file |
| M | plugins/baseline/include/Domain/AuthorizationsImpl.php | +5 | −6 | Go to diff View file |
| M | plugins/baseline/include/Domain/BaselineArtifact.php | +3 | −5 | Go to diff View file |
| M | plugins/baseline/include/Domain/BaselineRepository.php | +2 | −3 | Go to diff View file |
| M | plugins/baseline/include/Domain/BaselineService.php | +1 | −2 | Go to diff View file |
| M | plugins/baseline/include/Domain/ComparisonRepository.php | +2 | −3 | Go to diff View file |
| M | plugins/baseline/include/Domain/ComparisonService.php | +1 | −2 | Go to diff View file |
| A | plugins/baseline/include/Domain/ProjectIdentifier.php | +31 | −0 | Go to diff View file |
| M | plugins/baseline/include/Domain/ProjectRepository.php | +1 | −2 | Go to diff View file |
| M | plugins/baseline/include/Domain/RoleAssignmentRepository.php | +1 | −2 | Go to diff View file |
| M | plugins/baseline/include/Domain/TransientBaseline.php | +1 | −2 | Go to diff View file |
| M | plugins/baseline/include/Domain/TransientComparison.php | +1 | −3 | Go to diff View file |
| M | plugins/baseline/tests/unit/Adapter/BaselineArtifactRepositoryAdapterTest.php | +14 | −10 | Go to diff View file |
| M | plugins/baseline/tests/unit/Domain/BaselineServiceTest.php | +0 | −1 | Go to diff View file |
| M | plugins/baseline/tests/unit/Factory/BaselineArtifactBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/baseline/tests/unit/Factory/BaselineFactory.php | +2 | −2 | Go to diff View file |
| M | plugins/baseline/tests/unit/Factory/ProjectFactory.php | +8 | −5 | Go to diff View file |
| M | plugins/baseline/tests/unit/Factory/TransientComparisonFactory.php | +2 | −2 | Go to diff View file |
| M | plugins/baseline/tests/unit/Stub/BaselineRepositoryStub.php | +3 | −3 | Go to diff View file |
| M | plugins/baseline/tests/unit/Stub/ComparisonRepositoryStub.php | +3 | −3 | Go to diff View file |
| M | plugins/baseline/tests/unit/Stub/FullAccessAuthorizationsStub.php | +3 | −3 | Go to diff View file |
| M | plugins/baseline/tests/unit/Stub/ProjectRepositoryStub.php | +6 | −6 | Go to diff View file |