Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Move the main DAO of the pull request plugin to prepared statements and PDO

Download Browse

This contribution should not change anything at the functionnal level, it is only a technical change leveraging what has been introduced by commit 75c536e1254d78be0792f09c7c15ef6328c64135. There is changes outside the DAO, there was a lot of boolean that were returned by the DAO to verify if the query was successful. These return values were almost never checked so they have been removed. With Tuleap\DB\DataAccessObject an exception is always thrown when a query fails. Other DAOs the pull request plugin will be dealt with in another contribution. This is part of request #11074: Move pull request plugin to prepared statements and PDO Change-Id: I88d725287f8d09d4c5bd0592543fbfd944154bf1

+141 −230
Thomas Gerbet (tgerbet) 2018-01-31 23:17
Thomas Gerbet (tgerbet) 2018-02-01 12:12
6cd3da6c23e49de955ed942e2c5b54e3808f4929
9ca00bfc63d47c6aa250ea7afc2a5989d502e5be
git #tuleap/stable/6cd3da6c23e49de955ed942e2c5b54e3808f4929

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Dao.php +87 −150 Go to diff View file
M plugins/pullrequest/include/PullRequest/Factory.php +25 −27 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCloser.php +7 −7 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCreator.php +2 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +2 −4 Go to diff View file
M plugins/pullrequest/tests/PullRequestCloserTest.php +7 −29 Go to diff View file
M plugins/pullrequest/tests/PullRequestUpdaterTest.php +9 −10 Go to diff View file
M tests/lib/TuleapDbTestCase.class.php +2 −1 Go to diff View file