Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove superfluous UserAjaxRepresentation

Download Browse

UserAjaxInterpretation was needed because legacy ajax call to get possible users was not returning `display_name` property (it uses the generic `label` instead, that is common to all ListValue). We were forced to have three interfaces for user: * User: the assignee of a card * UserAjaxRepresentation: the possible assignees * UserForPeoplePicker: mixin of UserAjaxRepresentation and DataFormat so that select2 can display possible assignees in the dropdown & selection. With this commit, now legacy ajax call returns an additional property `display_name` so that the result are compliant with taskboard's User interface. This reduces the number of interfaces for user: * User: still the assignee of a card * UserForPeoplePicker: more or less a mixin of User and DataFormat for select2. No functional changes (except in the ajax call response). Part of: story #14151 Update the assigned-to semantic of a card Change-Id: I80dcdeeb5a168e5293e69746f36f8d12d8ea8dd7

+45 −47
Nicolas Terray (nterray) 2020-01-22 09:30
Nicolas Terray (nterray) 2020-01-22 11:12
6cf3be4520186c46725d2412cd969d4e48c0c959
3ad1d8ed6e085184f7eae5502992c6e9b03a83dc
git #tuleap/stable/6cf3be4520186c46725d2412cd969d4e48c0c959

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/CardAssignees.test.ts +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/Editor/Assignees/PeoplePicker.test.ts +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/Editor/Assignees/PeoplePicker.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-actions.test.ts +6 −6 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-actions.ts +8 −9 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-mutations.test.ts +6 −6 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/card/type.ts +2 −11 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/type.ts +5 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_UsersValue.class.php +6 −3 Go to diff View file
M plugins/tracker/phpunit/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_UsersValueTest.php +8 −6 Go to diff View file