Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove unused CampaignStatusChangeUnknownValueException class

Download Browse

This exception can never be thrown because the value we verify can only be instantiated with those two values. As a result the exception can never be thrown in any real life scenario. This sort of situation is better handled at the type system level than during runtime: no execution cost and we are certain the verification is always done even if we reuse this value somewhere else. This is part of request #20088 Improve the management of closed campaigns Change-Id: I591b80aea3fa1d14f8a73b2372144705d15e31fa

+15 −80
Thomas Gerbet (tgerbet) 2021-04-23 10:59
Thomas Gerbet (tgerbet) 2021-04-23 10:59
6d45bdb0ca8fc7bc49f621ccb7addfc5b9776358
04e3375f10dab0bed489d4f3ddf3732f38590b67
git #tuleap/stable/6d45bdb0ca8fc7bc49f621ccb7addfc5b9776358

Modified Files

Side by side diff
Inline diff
Name
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignArtifactUpdateFieldValuesBuilder.php +6 −9 Go to diff View file
D plugins/testmanagement/include/TestManagement/REST/v1/CampaignStatusChangeUnknownValueException.php +0 −29 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignUpdater.php +4 −1 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +5 −2 Go to diff View file
M plugins/testmanagement/tests/unit/TestManagement/REST/v1/CampaignArtifactUpdateFieldValuesBuilderTest.php +0 −39 Go to diff View file