Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Split mapped field retrieval out of FreestyleMappingFactory

Download Browse

part of request #39022 Moving a card in Taskboard can have side effects No functional change. Unit, REST and DB integration tests should pass. Why? This series of refactorings has the goal to make it easy to write a "domain" API to find the current column of a given card. This requires us to know which field in the card's tracker is "mapped" (either freestyle or status semantic). We start by simplifying the freestyle mapping part. FreestyleMappingFactory did not have clear responsibilities. It is now split in two: FreestyleMappedFieldRetriever (that focuses on the mapped field), and the rest for values. The factory itself will be renamed later. Added interfaces before DB queries. Interfaces will allow us to make the DAO final and write stubs to replace it in unit tests. Also removed static build methods. The final, top-most endpoints should have the responsibility of instantiating everything, so that they can substitute interfaces with caches if needed. Instantiation should not be a responsibility of individual objects. Change-Id: I61881f00bf082fe074ac842d997a0779de59b8e5

+324 −171
Joris MASSON (jmasson) 2024-08-21 11:53
Joris MASSON (jmasson) 2024-08-21 14:57
6df640834c2572c71814de040ed552a05ef86c42
5bf02d39e845f78f0a6f449d365f9c66c9c02c30
git #tuleap/stable/6df640834c2572c71814de040ed552a05ef86c42

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetriever.php +0 −5 Go to diff View file
A plugins/taskboard/include/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappedFieldRetriever.php +48 −0 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappingDao.php +10 −4 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappingFactory.php +1 −16 Go to diff View file
A plugins/taskboard/include/Column/FieldValuesToColumnMapping/Freestyle/SearchMappedField.php +34 −0 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/MappedFieldRetriever.php +4 −23 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/MappedValuesRetriever.php +0 −9 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/TrackerMappingPresenterBuilder.php +13 −2 Go to diff View file
M plugins/taskboard/include/REST/v1/CardRepresentationBuilder.php +14 −1 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +15 −4 Go to diff View file
M plugins/taskboard/include/Tracker/TrackerPresenterCollectionBuilder.php +0 −11 Go to diff View file
M plugins/taskboard/include/taskboardPlugin.php +14 −1 Go to diff View file
M plugins/taskboard/tests/integration/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappingDaoTest.php +4 −3 Go to diff View file
A plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappedFieldRetrieverTest.php +85 −0 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappingFactoryTest.php +2 −68 Go to diff View file
A plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/SearchMappedFieldStub.php +48 −0 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/MappedFieldRetrieverTest.php +32 −24 Go to diff View file