stable
Clone or download
The shim is no more needed for them. To avoid a potentially dangerous DB migration, the existing icon ID are kept as is. Instead of directly the icon ID we now search in lookup table the corresponding FA icon. This will also makes easier future migrations to new versions because we do not need to strictly adhere to the FA naming system. The easiest way to test the patch is to open the add/edit modal of the service and to check if all the icons are properly displayed in the selectbox. Note there is an issue with the TripAdvisor icon which was introduced by 78cb0e1b3dc34eb0a81fab1935b2426eea41fa02 and will dealt with in a dedicated contribution. Part of request #17110: Update to Font Awesome 5 Change-Id: Ic815d086217851b994287f40fbb2a758a5c45e5e
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboardService.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/ServiceDocman.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git/GitService.php | +1 | −1 | Go to diff View file |
| M | plugins/hudson/include/HudsonService.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/include/ServiceMediawiki.class.php | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/include/ProFTPd/ServiceProFTPd.class.php | +1 | −1 | Go to diff View file |
| M | plugins/svn/include/SVN/ServiceSvn.php | +1 | −1 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/Service.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/ServiceTracker.class.php | +1 | −1 | Go to diff View file |
| M | src/common/FRS/ServiceFile.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Service.class.php | +12 | −13 | Go to diff View file |
| M | src/common/Project/Service/ProjectDefinedService.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Service/ServiceIconValidator.php | +2999 | −602 | Go to diff View file |
| M | src/common/Project/Service/ServicePresenter.php | +1 | −1 | Go to diff View file |
| M | src/common/svn/ServiceSVN.class.php | +1 | −1 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/BaseProjectAdminAddModal.vue | +1 | −0 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/BaseProjectAdminEditModal.vue | +1 | −0 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/BaseSiteAdminAddModal.vue | +1 | −0 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/BaseSiteAdminEditModal.vue | +1 | −0 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/Service/IconSelector.vue | +9 | −12 | Go to diff View file |
| M | src/scripts/project/admin/services/src/components/SidebarPreviewer.vue | +4 | −3 | Go to diff View file |
| M | src/templates/project/admin/services/services.mustache | +4 | −4 | Go to diff View file |
| M | tests/unit/common/Project/Service/ServicePOSTDataBuilderTest.php | +1 | −1 | Go to diff View file |