Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refacto: UserCanPrioritize instead of plain \PFUser

Download Browse

This is part of story #20111 change features priority This patch aims to use UserCanPrioritize object, instead of PFUser in ProgramManagement plugin when it's possible. UserCanPrioritize can only be used when we treated a program with a user and some checks were done. It's not possible to change all PFUser to this new object. No expected changes. How to test: - Have 2 users: -> one can prioritize -> another not (anonymous for example) - Go to program service => With first user, you can move features => With anonymous, you can't Change-Id: I4651add4a4a99a906491c2a652689f8527296b5e

+185 −76
Benjamin Bouillot (ben.bouillot) 2021-05-04 13:35
Benjamin Bouillot (ben.bouillot) 2021-05-04 13:51
6f1b9f5c60f195aaa74e3897b72e3e60df86ea56
fc8df458469f4e6193cdb2019d8b2b5ebd39861e
git #tuleap/stable/6f1b9f5c60f195aaa74e3897b72e3e60df86ea56

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessor.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessor.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ArtifactTopBacklogActionBuilder.php +4 −5 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/MassChangeTopBacklogActionBuilder.php +4 −5 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChange.php +9 −5 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifier.php +7 −10 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/FeatureAddition.php +4 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/FeatureRemoval.php +5 −4 Go to diff View file
A plugins/program_management/include/Domain/UserCanPrioritize.php +66 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessorTest.php +4 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessorTest.php +4 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifierTest.php +9 −27 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureAdditionTest.php +11 −9 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureRemovalTest.php +4 −2 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyPrioritizeFeaturePermissionStub.php +52 −0 Go to diff View file