Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Extract user registration in dedicated objects

Download Browse

In order to have better responsibilities and better test coverage, processing of user registration form is extracted in smaller dedicated objects. Suggested starting point for the review: src/common/User/Account/Register/RegisterFormProcessor.php No functional changes in user registration. Part of request #29614: Invited users shouldn't be mandated to re-confirm their email Change-Id: I027b08a1657a5914635bb90912b89c811fd44635

+938 −187
Nicolas Terray (nterray) 2023-01-16 12:05
Nicolas Terray (nterray) 2023-01-17 08:17
6f67ed22227ba5dd86e8c71fc38032161a7b999b
eab460e64bf373d3c8417a8870f56ab6e0824fcd
git #tuleap/stable/6f67ed22227ba5dd86e8c71fc38032161a7b999b

Modified Files

Side by side diff
Inline diff
Name
M plugins/ldap/include/LDAP_UserManager.class.php +1 −1 Go to diff View file
M src/common/Request/RouteCollector.php +13 −7 Go to diff View file
A src/common/User/Account/Register/AfterSuccessfulUserRegistration.php +125 −0 Go to diff View file
A src/common/User/Account/Register/AfterSuccessfulUserRegistrationHandler.php +38 −0 Go to diff View file
A src/common/User/Account/Register/ConfirmationPageDisplayer.php +95 −0 Go to diff View file
A src/common/User/Account/Register/IDisplayConfirmationPage.php +36 −0 Go to diff View file
M src/common/User/Account/Register/IDisplayRegisterForm.php +7 −0 Go to diff View file
A src/common/User/Account/Register/IValidateFormAndCreateUser.php +34 −0 Go to diff View file
M src/common/User/Account/Register/RegisterFormHandler.php +1 −1 Go to diff View file
M src/common/User/Account/Register/RegisterFormProcessor.php +12 −157 Go to diff View file
A src/common/User/IGenerateMailConfirmationCode.php +28 −0 Go to diff View file
M src/common/User/MailConfirmationCodeGenerator.class.php +5 −13 Go to diff View file
A tests/unit/common/User/Account/Register/AfterSuccessfulUserRegistrationHandlerStub.php +56 −0 Go to diff View file
A tests/unit/common/User/Account/Register/AfterSuccessfulUserRegistrationTest.php +210 −0 Go to diff View file
A tests/unit/common/User/Account/Register/IDisplayConfirmationPageStub.php +82 −0 Go to diff View file
M tests/unit/common/User/Account/Register/IDisplayRegisterFormStub.php +22 −8 Go to diff View file
A tests/unit/common/User/Account/Register/IValidateFormAndCreateUserStub.php +54 −0 Go to diff View file
A tests/unit/common/User/Account/Register/RegisterFormProcessorTest.php +76 −0 Go to diff View file
A tests/unit/common/User/IGenerateMailConfirmationCodeStub.php +43 −0 Go to diff View file