stable

Clone or download

Read-only

refactor: remove usage of deprecated call to Artifact::createNewChangeset

part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: - when the status semantic is not defined, - when there are only open values (no closed values per semantic status configuration), In each case, when you push a commit in the main branch of a GitLab repository integrated with Tuleap, and its configuration allows closing artifacts, then a comment will still be added on the artifact to explain the problem. Notes: There is still another call in the same class but it is not touched to keep this contribution smaller. Change-Id: I25a1e55588d37fb628e5195b913acae3116bba19

Modified Files

Name
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushCommitArtifactUpdater.php +23 −47 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +196 −73 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitArtifactUpdaterTest.php +56 −49 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandlerTest.php +17 −15 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/CommentOnlyChangesetCreator.php +68 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/CreateCommentOnlyChangeset.php +40 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/CreateNewChangeset.php +35 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.php +1 −7 Go to diff View file
A plugins/tracker/tests/unit/Stub/CreateCommentOnlyChangesetStub.php +72 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/CreateNewChangesetStub.php +58 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/CommentOnlyChangesetCreatorTest.php +117 −0 Go to diff View file