stable

Clone or download

Read-only

Split files that contains more than one class in Docman

PSR-1 says that "each class is in a file by itself": https://www.php-fig.org/psr/psr-1/#3-namespace-and-class-names Technical refactoring, no functional changes. Only the minimal has been done. The existing issues inside the classes has not been fix (ex: private method named prefixed by underscore). This is small step towards PSR-4 compliance. Psalm baseline has been updated. Work has been mostly automated by usage of psr4-switcher[0] and rector[1]. Manual adjustment has been made for copyright headers and phpcs:ignore on the classname. Part of request #16620: One class per file [0] https://github.com/migrify/psr4-switcher [1] https://github.com/rectorphp/rector/blob/master/docs/rector_rules_overview.md#multipleclassfiletopsr4classesrector Change-Id: Ib115f7082ddaec56188855dd803fd0794b15b055

Modified Files

Name
M plugins/docman/include/Docman_Actions.class.php +0 −1 Go to diff View file
M plugins/docman/include/Docman_CoreActions.class.php +0 −1 Go to diff View file
M plugins/docman/include/Docman_EmbeddedFile.class.php +0 −2 Go to diff View file
M plugins/docman/include/Docman_Empty.class.php +0 −2 Go to diff View file
M plugins/docman/include/Docman_Error_PermissionDenied.class.php +0 −3 Go to diff View file
M plugins/docman/include/Docman_File.class.php +0 −1 Go to diff View file
D plugins/docman/include/Docman_Filter.class.php +0 −563 Go to diff View file
A plugins/docman/include/Docman_Filter.php +95 −0 Go to diff View file
A plugins/docman/include/Docman_FilterDate.php +125 −0 Go to diff View file
A plugins/docman/include/Docman_FilterDateAdvanced.php +117 −0 Go to diff View file
A plugins/docman/include/Docman_FilterGlobalText.php +36 −0 Go to diff View file
A plugins/docman/include/Docman_FilterItemType.php +31 −0 Go to diff View file
A plugins/docman/include/Docman_FilterItemTypeAdvanced.php +31 −0 Go to diff View file
A plugins/docman/include/Docman_FilterList.php +72 −0 Go to diff View file
A plugins/docman/include/Docman_FilterListAdvanced.php +86 −0 Go to diff View file
A plugins/docman/include/Docman_FilterOwner.php +45 −0 Go to diff View file
A plugins/docman/include/Docman_FilterText.php +40 −0 Go to diff View file
M plugins/docman/include/Docman_FolderFactory.class.php +0 −3 Go to diff View file
M plugins/docman/include/Docman_HTTPActions.class.php +0 −1 Go to diff View file
M plugins/docman/include/Docman_HTTPController.class.php +0 −2 Go to diff View file
D plugins/docman/include/Docman_HtmlFilter.class.php +0 −240 Go to diff View file
A plugins/docman/include/Docman_HtmlFilter.php +72 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterDate.php +38 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterDateAdvanced.php +43 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterFactory.php +50 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterList.php +52 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterListAdvanced.php +37 −0 Go to diff View file
A plugins/docman/include/Docman_HtmlFilterText.php +37 −0 Go to diff View file
D plugins/docman/include/Docman_ItemAction.class.php +0 −231 Go to diff View file
A plugins/docman/include/Docman_ItemAction.php +62 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionApproval.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionCopy.php +35 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionCut.php +35 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionDelete.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionDetails.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionHistory.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionMove.php +36 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionNewDocument.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionNewFolder.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionNewVersion.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionNotifications.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionPaste.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionPermissions.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ItemActionUpdate.php +32 −0 Go to diff View file
A plugins/docman/include/Docman_ListMetadata.php +73 −0 Go to diff View file
M plugins/docman/include/Docman_Log.class.php +0 −2 Go to diff View file
R plugins/docman/include/Docman_Metadata.class.php Go to diff View file
M plugins/docman/include/Docman_MetadataComparator.class.php +0 −2 Go to diff View file
D plugins/docman/include/Docman_MetadataHtml.class.php +0 −582 Go to diff View file
A plugins/docman/include/Docman_MetadataHtml.php +142 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlDate.php +54 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlFactory.php +67 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlList.php +130 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlObsolescence.php +69 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlOwner.php +54 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlString.php +44 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataHtmlText.php +45 −0 Go to diff View file
M plugins/docman/include/Docman_MetadataSqlQueryChunk.class.php +0 −2 Go to diff View file
D plugins/docman/include/Docman_MetadataValue.class.php +0 −229 Go to diff View file
A plugins/docman/include/Docman_MetadataValue.php +80 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataValueList.php +55 −0 Go to diff View file
A plugins/docman/include/Docman_MetadataValueScalar.php +116 −0 Go to diff View file
M plugins/docman/include/Docman_NotificationsManager_Add.class.php +0 −3 Go to diff View file
M plugins/docman/include/Docman_NotificationsManager_Delete.class.php +0 −3 Go to diff View file
M plugins/docman/include/Docman_NotificationsManager_Move.class.php +0 −3 Go to diff View file
M plugins/docman/include/Docman_NotificationsManager_Subscribers.class.php +0 −2 Go to diff View file
M plugins/docman/include/Docman_Report.class.php +0 −2 Go to diff View file
D plugins/docman/include/Docman_ReportColumn.class.php +0 −233 Go to diff View file
A plugins/docman/include/Docman_ReportColumn.php +114 −0 Go to diff View file
M plugins/docman/include/Docman_ReportColumnFactory.class.php +0 −4 Go to diff View file
A plugins/docman/include/Docman_ReportColumnList.php +39 −0 Go to diff View file
A plugins/docman/include/Docman_ReportColumnLocation.php +65 −0 Go to diff View file
A plugins/docman/include/Docman_ReportColumnTitle.php +51 −0 Go to diff View file
M plugins/docman/include/Docman_ReportFactory.class.php +1 −7 Go to diff View file
M plugins/docman/include/Docman_SOAPController.class.php +0 −2 Go to diff View file
M plugins/docman/include/Docman_SettingsBo.class.php +0 −2 Go to diff View file
D plugins/docman/include/Docman_SqlFilter.class.php +0 −402 Go to diff View file
A plugins/docman/include/Docman_SqlFilter.php +99 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterDate.php +95 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterDateAdvanced.php +61 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterFactory.php +55 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterGlobalText.php +64 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterListAdvanced.php +39 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterOwner.php +39 −0 Go to diff View file
A plugins/docman/include/Docman_SqlFilterText.php +44 −0 Go to diff View file
R plugins/docman/include/Docman_SqlReportColumn.class.php Go to diff View file
A plugins/docman/include/Docman_SqlReportColumnFactory.php +38 −0 Go to diff View file
D plugins/docman/include/Docman_ValidateFilter.class.php +0 −91 Go to diff View file
A plugins/docman/include/Docman_ValidateFilter.php +43 −0 Go to diff View file
A plugins/docman/include/Docman_ValidateFilterDate.php +45 −0 Go to diff View file
A plugins/docman/include/Docman_ValidateFilterFactory.php +37 −0 Go to diff View file
A plugins/docman/include/Docman_ValidateMetadataIsNotEmpty.php +38 −0 Go to diff View file
A plugins/docman/include/Docman_ValidateMetadataListIsNotEmpty.php +57 −0 Go to diff View file
A plugins/docman/include/Docman_ValidatePresenceOf.php +31 −0 Go to diff View file
A plugins/docman/include/Docman_ValidateValueNotEmpty.php +31 −0 Go to diff View file
R plugins/docman/include/Docman_Validator.class.php Go to diff View file
M plugins/docman/include/Docman_Widget_ProjectEmbedded.class.php +0 −1 Go to diff View file
M plugins/docman/include/Docman_Wiki.class.php +0 −2 Go to diff View file
M plugins/docman/include/docmanPlugin.php +0 −19 Go to diff View file
A plugins/docman/include/view/Docman_MetadataHtmlEmbeddedFile.php +46 −0 Go to diff View file
A plugins/docman/include/view/Docman_MetadataHtmlEmpty.php +41 −0 Go to diff View file
A plugins/docman/include/view/Docman_MetadataHtmlFile.php +46 −0 Go to diff View file
A plugins/docman/include/view/Docman_MetadataHtmlLink.php +45 −0 Go to diff View file
A plugins/docman/include/view/Docman_MetadataHtmlWiki.php +45 −0 Go to diff View file
M plugins/docman/include/view/Docman_View_Admin_LockInfos.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Admin_MetadataImport.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Admin_View.class.php +0 −4 Go to diff View file
M plugins/docman/include/view/Docman_View_AjaxReferenceTooltip.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_AjaxReferenceTooltipError.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_ApprovalCreate.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Delete.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Details.class.php +0 −15 Go to diff View file
M plugins/docman/include/view/Docman_View_DocmanError.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Edit.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Empty.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Error.class.php +0 −2 Go to diff View file
D plugins/docman/include/view/Docman_View_GetSpecificFieldsVisitor.class.php +0 −221 Go to diff View file
A plugins/docman/include/view/Docman_View_GetSpecificFieldsVisitor.php +74 −0 Go to diff View file
M plugins/docman/include/view/Docman_View_Install.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Installed.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionEditProperties.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionMove.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionNotifications.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionStatistics.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemDetailsSectionUpdate.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Move.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_NewFolder.class.php +0 −4 Go to diff View file
M plugins/docman/include/view/Docman_View_NewVersion.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_New_FolderSelection.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Paste.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_PasteInProgress.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_PermissionsForItem.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_PositionWithinFolder.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_ProjectError.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_RawTree.class.php +0 −5 Go to diff View file
M plugins/docman/include/view/Docman_View_ReportSettings.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Table.class.php +0 −2 Go to diff View file
M plugins/docman/include/view/Docman_View_Tree.class.php +0 −3 Go to diff View file
M plugins/docman/include/view/Docman_View_Update.class.php +0 −3 Go to diff View file
M tests/psalm/tuleap-baseline.xml +630 −278 Go to diff View file