Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: add interfaces in front of FormElementFactory

Download Browse

part of story #24969 [modal] add and remove links without types No functional change expected. Having interfaces lets us use Stubs instead of mocks. We also split the responsibilities of "values by field" format to another dedicated class. Change-Id: I3abed02a56aedcd974ac7debc43f652dfabf0968

+677 −238
Joris MASSON (jmasson) 2022-03-17 10:23
Joris MASSON (jmasson) 2022-03-18 10:47
7022eed56d1445ef657eca63646c66a4e7d208fc
e47bcb96be80a4c81d0aeb7d8f290742d70661f9
git #tuleap/stable/7022eed56d1445ef657eca63646c66a4e7d208fc

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/REST/v1/Kanban/KanbanItemsResource.php +5 −4 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +7 −6 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/ExecutionsResource.class.php +5 −4 Go to diff View file
M plugins/tracker/include/REST/Artifact/ArtifactCreator.class.php +14 −6 Go to diff View file
M plugins/tracker/include/REST/Artifact/Changeset/Value/FieldsDataBuilder.php +7 −35 Go to diff View file
A plugins/tracker/include/REST/Artifact/Changeset/Value/FieldsDataFromValuesByFieldBuilder.php +59 −0 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +5 −4 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/Value/AddDefaultValuesToFieldsData.php +30 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/RetrieveUsedFields.php +30 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElementFactory.php +5 −6 Go to diff View file
M plugins/tracker/tests/unit/REST/Artifact/ArtifactUpdaterTest.php +62 −65 Go to diff View file
M plugins/tracker/tests/unit/REST/Artifact/Changeset/Value/FieldsDataBuilderTest.php +185 −108 Go to diff View file
A plugins/tracker/tests/unit/REST/Artifact/Changeset/Value/FieldsDataFromValuesByFieldBuilderTest.php +211 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/RetrieveUsedFieldsStub.php +52 −0 Go to diff View file