Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Reject feature drop when user cannot see a Mirrored Program Increment

Download Browse

part of request #23383 Bad request error when planning a feature How to test: Set up program management with at least one Team as a private project. Your current user: - must not be site administrator - must be member of the Program project - must not see the private project (not a project member) - must be in a user group allowed to plan features in Program Management admin When you browse the Program Management app and you try to drop a feature in a Program Increment, you should see a modal pop-up with a "Bad request" error. Before this patch, the error would be silently ignored. Change-Id: Ic750b7cb249f9c1b9fddcce382e248d4384be7a4

+222 −32
Joris MASSON (jmasson) 2021-11-25 11:31
Joris MASSON (jmasson) 2021-11-25 15:27
702be4d97e935558196a4807dc8dd310ba116af7
eaeea27e92ce374aca472d21cb3061fd5b555d24
git #tuleap/stable/702be4d97e935558196a4807dc8dd310ba116af7

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessor.php +6 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/UserStoriesInMirroredProgramIncrementsPlanner.php +1 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ArtifactUpdatedHandler.php +7 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessor.php +8 −1 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/Feature/Content/UserStoryPlanException.php +27 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/PlanUserStoriesInMirroredProgramIncrements.php +5 −0 Go to diff View file
M plugins/program_management/include/Domain/Team/MirroredTimebox/MirroredProgramIncrementIdentifier.php +31 −0 Go to diff View file
A plugins/program_management/include/Domain/Team/MirroredTimebox/MirroredProgramIncrementIsNotVisibleException.php +41 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorTest.php +11 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/UserStoriesInMirroredProgramIncrementsPlannerTest.php +21 −4 Go to diff View file
M plugins/program_management/tests/unit/Domain/Team/MirroredTimebox/MirroredProgramIncrementIdentifierTest.php +48 −21 Go to diff View file
M plugins/program_management/tests/unit/Stub/PlanUserStoriesInMirroredProgramIncrementsStub.php +16 −2 Go to diff View file