stable
Clone or download
Read-only
request #9527: OpenID Connect plugin does not work with Keycloak
The issue is caused by the fact that Keycloak adds a parameter not specified by the specification [0][1]. This parameter name contains a dash which make the library currently used by Tuleap to process the token crash when the fields of the token response object are generated. This contribution replaces the library usage to process the token request and response. [0] https://openid.net/specs/openid-connect-core-1_0.html#TokenResponse [1] https://tools.ietf.org/html/rfc6749#section-1.4.1 Change-Id: I62724dab13f6cc784144d866209b02f7e0ffbb1b
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Flow.php | +27 | −16 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/IncorrectTokenResponseTypeException.php | +29 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/IncorrectlyFormattedTokenResponseException.php | +29 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/TokenRequest.php | +43 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/TokenRequestCreator.php | +64 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/TokenRequestSender.php | +46 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/TokenResponse.php | +79 | −0 | Go to diff View file |
A | plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Token/TokenResponseException.php | +25 | −0 | Go to diff View file |
M | plugins/openidconnectclient/include/openidconnectclientPlugin.class.php | +6 | −0 | Go to diff View file |
A | plugins/openidconnectclient/phpunit/.simpletest_skip | +0 | −0 | Go to diff View file |
A | plugins/openidconnectclient/phpunit/Authentication/FlowTest.php | +112 | −0 | Go to diff View file |
A | plugins/openidconnectclient/phpunit/Authentication/Token/TokenResponseTest.php | +92 | −0 | Go to diff View file |
A | plugins/openidconnectclient/phpunit/bootstrap.php | +21 | −0 | Go to diff View file |
D | plugins/openidconnectclient/tests/Authentication/FlowTest.php | +0 | −91 | Go to diff View file |
M | src/composer.json | +14 | −12 | Go to diff View file |
M | src/composer.lock | +3 | −3 | Go to diff View file |