Implements request #35133 User should be able to abandon broken pull-requests How to test: Without applying this patch, do the following: - Pick up a pull-request, and note its id (can be found in the url) - In the `plugin_pullrequest_git_reference_tab` set `status=2` for the chosen pull-request. At this step, your pull-request should be considered broken - Go to the pull-requests hompage --> You should get a "Pull-request is not accesible anymore" modal - Try to open your pull-request --> You get a "Pull-request is not accessible anymore" modal, the pul-request informations do not load. - Apply the patch, and run `make post-checkout` - Go to the pull-requests hompage --> You are not greeted with an error modal anymore --> There is a notification bubble in the tab's label --> Your pull-request has an [Error] badge - Access your pull-request --> The pull-request informations are loaded --> There is an empty state in the left pane saying "Oops! It seems that your pull-request is broken" --> It contains an [Abandon] button if you have the permission to abandon pull-requests --> The right pane displays an error saying that the git ref is broken --> It only contains a [Abandon] button (if you have the permission) --> There is no [Commits] and [Changes] tabs [0] --> If you try to access these tabs by forging their urls, you get redirected to the overview tab - Abandon the pull-request --> It should succeed --> There is no [reopen] button Change-Id: I41c2c06d8ac986f1ebf2fe43bfe01eb5a008bdee

+802 −177

Author

Thomas Gorka (tgorka) 2023-11-16 14:10

Committer

Thomas Gorka (tgorka) 2023-11-30 17:00

Hash 72d9109f312dbd7d1e61ca824284818eb0d54a81

Parent afcce460ef63073e635395f5f46db8849f034442

Reference git #tuleap/stable/72d9109f312dbd7d1e61ca824284818eb0d54a81