Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: send one big event to Tracker instead of small events

Download Browse

part of request #27896 Smart commit is not smart enough No functional change expected in the Git closing references feature: - if you push two commits that have a "closing comment" for the same artifact, Tracker workflow manager will still comment twice on the artifact. Notes: Instead of sending an event for each commit message, we send one big event for the entire branch that was pushed. It contains all the commit messages that we could read. If the code can't read one commit message, it does not stop and tries to read the next one. The single big event will allow us to deploy local caching to avoid trying to close again an artifact that has been closed in the same push. Change-Id: I69da9cc8d7e0f63f4e938806e446bfdb5c4b6d3f

+138 −161
Joris MASSON (jmasson) 2022-08-12 15:37
Joris MASSON (jmasson) 2022-08-17 09:42
753f664b9a8ba3b6c5b5f10b46aad585e1ca6899
79b2658764f6d5e6cda87e19a9e4046f0884072d
git #tuleap/stable/753f664b9a8ba3b6c5b5f10b46aad585e1ca6899

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Hook/Asynchronous/AsynchronousEventHandler.php +17 −32 Go to diff View file
R plugins/git/tests/unit/Hook/DefaultBranchPush/CommitAnalysisOrderTest.php Go to diff View file
M plugins/git/include/Hook/DefaultBranchPush/DefaultBranchPushProcessor.php +31 −15 Go to diff View file
M plugins/git/include/Hook/DefaultBranchPush/DefaultBranchPushReceived.php +0 −12 Go to diff View file
M plugins/git/tests/unit/Hook/Asynchronous/AsynchronousEventHandlerTest.php +4 −13 Go to diff View file
M plugins/git/tests/unit/Hook/DefaultBranchPush/DefaultBranchPushProcessorTest.php +24 −27 Go to diff View file
M plugins/git/tests/unit/Hook/DefaultBranchPush/DefaultBranchPushReceivedTest.php +4 −21 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Closure/ArtifactClosingReferencesHandler.php +11 −7 Go to diff View file
M plugins/tracker/tests/unit/Artifact/Closure/ArtifactClosingReferencesHandlerTest.php +24 −21 Go to diff View file
M src/common/Event/Events/PotentialReferencesReceived.php +7 −5 Go to diff View file
R plugins/git/include/Hook/DefaultBranchPush/CommitAnalysisOrder.php Go to diff View file
M tests/lib/Stubs/ExtractReferencesStub.php +16 −8 Go to diff View file