Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Adjust all icons of cross-tracker widget

Download Browse

fixes request #36856 Save icon no longer shown in cross-tracker search widget How to test: When you modify a cross-tracker report, for example by editing the query or choosing another tracker, then the "save the report" button should have a "save" icon. Other icons should still show up. Why? aria-hidden attribute is added to all icons except the "cross" icon to remove a tracker from the list. This one should not be an icon but should be a button, but that is outside the scope of this patch. This attribute hides the icon from screen readers, because they are here for "cosmetic" purpose only. Set "fa-solid" class for all icons missing it. Also added a margin to the "info" icon that was glued to the text. Change-Id: I162465de34100cc190f7ac21e42f1ba95d134147

+62 −24
Joris MASSON (jmasson) 2024-02-23 15:46
Joris MASSON (jmasson) 2024-02-23 16:06
756953434d066756521951233ef9071c0959781c
46ef503ee2dd08f3007f4b1dabdbd33bcdd38b13
git #tuleap/stable/756953434d066756521951233ef9071c0959781c

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/scripts/cross-tracker/src/components/ArtifactTable.vue +5 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/components/ExportCSVButton.vue +3 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/ReadingMode.vue +8 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/TrackerListReadingMode.vue +4 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/QueryEditor.vue +4 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/TrackerListWritingMode.vue +6 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/TrackerSelection.test.ts +3 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/TrackerSelection.vue +8 −5 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/WritingMode.vue +1 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/__snapshots__/QueryEditor.test.ts.snap +2 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/__snapshots__/TrackerListWritingMode.test.ts.snap +8 −4 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/__snapshots__/TrackerSelection.test.ts.snap +6 −3 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/themes/_query-edition.scss +4 −0 Go to diff View file