stable
Clone or download
Read-only
Part of story #11667 display diff side by side - When you try to submit an empty inline comment, your browser should stop you and tell you the textarea is required. - When you submit an inline comment, a spinner icon is shown on the "Comment" button. - No other functional changes expected. I took the opportunity to rearrange file-diff's code in the controller instead of the directive's link function. Also upgrade CodeMirror version. It was pinned because we needed CodeMirror to be present on window. Now that we use webpack and import it, we no longer care \o/ Change-Id: I3bc09520d339a1efb91ef8cf3cc3243209f5aa82
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/www/scripts/package-lock.json | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/package.json | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/po/template.pot | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/src/app/app.js | +4 | −0 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/src/app/file-diff/file-diff-controller.js | +144 | −4 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/src/app/file-diff/file-diff-directive.js | +2 | −158 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/src/app/file-diff/file-diff.tpl.html | +3 | −4 | Go to diff View file |
| A | plugins/pullrequest/www/scripts/src/app/file-diff/new-inline-comment-component.js | +55 | −0 | Go to diff View file |
| A | plugins/pullrequest/www/scripts/src/app/file-diff/new-inline-comment.html | +47 | −0 | Go to diff View file |
| M | plugins/pullrequest/www/themes/BurningParrot/css/includes/_file-diff.scss | +7 | −12 | Go to diff View file |