stable
Clone or download
Read-only
Part of story #10673: see BurnUp chart in agile dashboard Since commit 472245af83964f30ec8472f0217912811e2471d2, self strategy is not anymore used, we only have a descendant strategy. Therefore we don't need at all the strategy pattern. This means: BacklogStrategyFactory -> BacklogFactory DescendantBacklogStrategy -> Backlog ContentPresenterDescendant -> ContentPresenter No functional changes Note: The naming of getBacklog/getSelfBacklog in BacklogFactory should be improved to better reflect the intent between the two methods, but it should be done in another commit to not clutter this review. Change-Id: I4812fd40b57e1212cf702228565e408a6adc255e
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/BacklogItem/PaginatedBacklogItemsRepresentationsBuilder.class.php | +13 | −13 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/BacklogItem/SubBacklogItemProvider.class.php | +7 | −7 | Go to diff View file |
| R | plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/DescendantBacklogStrategy.class.php | Go to diff View file | ||
| R | plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/BacklogStrategyFactory.class.php | Go to diff View file | ||
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/BacklogItemCollectionFactory.class.php | +19 | −19 | Go to diff View file |
| D | plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/BacklogStrategy.class.php | +0 | −44 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/MilestoneParentLinker.php | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/MilestoneRepresentationBuilder.class.php | +6 | −6 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/Content/ContentPresenter.class.php | +78 | −14 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/Content/ContentPresenterBuilder.class.php | +16 | −16 | Go to diff View file |
| D | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/Content/ContentPresenterDescendant.class.php | +0 | −113 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/PanePresenterBuilderFactory.class.php | +6 | −6 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneResource.class.php | +14 | −14 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneResourceValidator.class.php | +23 | −23 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/ProjectBacklogResource.class.php | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/ProjectMilestonesResource.class.php | +4 | −4 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v2/ProjectBacklogResource.class.php | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/SequenceIdManager.php | +9 | −9 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboardRouterBuilder.php | +6 | −6 | Go to diff View file |
| M | plugins/agiledashboard/include/agiledashboardPlugin.class.php | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/include/autoload.php | +4 | −6 | Go to diff View file |
| R | plugins/agiledashboard/templates/pane-content-descendant-strategy.mustache | Go to diff View file | ||
| M | plugins/agiledashboard/tests/include/AgileDashboard/BacklogItem/SubBacklogItemProviderTest.php | +4 | −4 | Go to diff View file |
| M | plugins/agiledashboard/tests/include/AgileDashboard/Milestone/Backlog/AgileDashboard_Milestone_Backlog_BacklogItemCollectionFactoryTest.php | +9 | −8 | Go to diff View file |
| M | plugins/agiledashboard/tests/include/AgileDashboard/REST/v1/MilestoneResourceValidatorTest.php | +6 | −6 | Go to diff View file |
| M | plugins/agiledashboard/tests/include/AgileDashboard/SequenceIdManagerTest.php | +25 | −25 | Go to diff View file |
| M | plugins/agiledashboard/tests/include/MilestoneParentLinkerTest.php | +15 | −15 | Go to diff View file |
| M | plugins/cardwall/include/Pane.class.php | +3 | −3 | Go to diff View file |