stable
Clone or download
request #19265 🔥 Kill vue-gettext in the Artifact modal
How to test: - (cd plugins/tracker && npm install); (cd plugins/tracker/scripts/angular-artifact-modal && npm install) - then run "npm run build" in Agile Dashboard or TestManagement plugin - Vue components such as Text fields and the Follow-up comment editor are still translated in French - If you change a translation and run "make generate-po", the change is reflected in the .po file - "npm run watch" still functions in the tracker plugin (although it does not watch the artifact modal) - No other functional change expected. Notes: We cannot write the translated strings in Vue components. "angular-gettext-tools" cannot read Vue single-file components, so they will never be extracted this way. I could not pass gettextCatalog in the root Vue component like what is done for Vuex. At this step, there is no gettextCatalog, only gettextCatalogProvider (config phase). So this implementation relies on a "stateful module" with a setter called when we actually have a handle on gettextCatalog. Vue components must then call methods to get translated strings. It is better than before, although very annoying in Vue components. Change-Id: Ibe0366ca7efe3edbaa304aa58d3e0ecfcb41c879
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/webpack.common.js | +0 | −2 | Go to diff View file |
| M | plugins/testmanagement/webpack.common.js | +0 | −1 | Go to diff View file |
| M | plugins/tracker/build-manifest.json | +6 | −0 | Go to diff View file |
| D | plugins/tracker/gulpfile.js | +0 | −51 | Go to diff View file |
| M | plugins/tracker/package-lock.json | +276 | −3750 | Go to diff View file |
| M | plugins/tracker/package.json | +1 | −4 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/package-lock.json | +0 | −5 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/package.json | +0 | −1 | Go to diff View file |
| R | plugins/tracker/scripts/angular-artifact-modal/po/fr.po | Go to diff View file | ||
| M | plugins/tracker/scripts/angular-artifact-modal/src/common/CommonmarkSyntaxHelper.vue | +10 | −4 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/common/FormatSelector.test.js | +5 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/common/FormatSelector.vue | +13 | −3 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/common/RichTextEditor.test.js | +2 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/common/RichTextEditor.vue | +10 | −7 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/followups/FollowupEditor.test.js | +2 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/followups/FollowupEditor.vue | +2 | −1 | Go to diff View file |
| A | plugins/tracker/scripts/angular-artifact-modal/src/gettext-catalog.js | +41 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/helpers/local-vue.js | +1 | −9 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal.js | +4 | −3 | Go to diff View file |
| D | plugins/tracker/scripts/angular-artifact-modal/src/vue-initializer.js | +0 | −31 | Go to diff View file |
| M | tools/utils/scripts/webpack-rule-configs.js | +0 | −9 | Go to diff View file |