Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: move comment saving to a dedicated class

Download Browse

part of story #24969 [modal] add and remove links without types No functional change expected. Saving a comment for a new changeset should not be mixed among the workflow and fields value and stuff. Moving it to its own class makes it respect Single-Responsibility Principle better. Change-Id: I2e49ad600b1121b6159c02aeb744ad468acbf59a

+698 −192
Joris MASSON (jmasson) 2022-03-14 10:45
Joris MASSON (jmasson) 2022-03-14 18:14
79598c0409a532c9e031ca8256a0c0a8691e37ec
60fb68705c797aef84be7254a4da32f1ecd7d91d
git #tuleap/stable/79598c0409a532c9e031ca8256a0c0a8691e37ec

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php +7 −4 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationUpdateProcessorBuilder.php +7 −4 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php +7 −4 Go to diff View file
M plugins/taskboard/include/REST/v1/Card/CardPatcher.php +7 −4 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +7 −4 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +7 −4 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/ExecutionsResource.class.php +7 −4 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +7 −4 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Artifact.php +7 −4 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/Comment/CommentCreator.php +70 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/Comment/NewComment.php +141 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.php +65 −130 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImportBuilder.class.php +7 −4 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +17 −14 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/CommentCreatorTest.php +173 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/Comment/NewCommentTest.php +105 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetCreatorTest.php +7 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Tracker_ArtifactTest.php +7 −4 Go to diff View file
A tests/lib/Builders/ProjectUGroupTestBuilder.php +43 −0 Go to diff View file